Repository navigation
π docs: clarify per-repo DCO routing at level 6 - #15044
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
There was a problem hiding this comment.
Read this against v5 rather than the diff alone; the new wording matches the code.
- "routes by author kind: 070 (hive/self-authored), 071 (human), 072 (clanker)" β matches the stage table at
src/docs/labels-and-control-signals.md:462and thestageAuthorKindsplit insrc/pkg/github/automerge/automerge_stage_labels.go:715/:1135. - "Where DCO is required (detected β¦ or configured via
governor.labels.stage.dco.required)" βdcoRequiredatautomerge_stage_labels.go:666-676consults the per-repo override first, thenobs.Detail.DCOGatefor the head; the key resolves toStageLabelsConfig.DCO(src/pkg/config/config.go:2706,yaml:"dco") βStageDCOConfig.Required(:2760,yaml:"required"). - The
labels-and-control-signals.md#dco--no-dco--the-hive-owned-sign-off-signalanchor resolves to the heading at:545. scale-envelope.mdcitation bump toclient.go:4780-4790is exact:RankActionableIssuesspanssrc/pkg/github/client.go:4780-4790onv5.
Looks correct to me; docs-only, no behaviour change.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 095-pre-merge-soak β 060-reviewed: required-check-pending:Sign-off survives the squash |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Fixes hivecommons#15040 Hive-Run: hivecommons#15040 Hive-Plan: docs-currency DCO routing clarification Hive-Spec: hivecommons#15040#ungated-repo-behavior Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
aeb3773 to
7400da1
Compare
There was a problem hiding this comment.
Cross-checked the new wording against the tree at 7400da1; it is accurate. Looks correct to me.
governor.labels.stage.dco.requiredexists (src/pkg/config/config.go:2750-2762,StageDCOConfig.Required), and its comment states the same per-repo gating this row now describes: labels written everywhere, stage routing and nudge only where DCO is required or detected.- The 070/071/072 split by author kind matches
labels-and-control-signals.md:225-227and the "The pair is mutually exclusive" paragraph at:559-566; the new[DCO routing]link targets the### \dco` / `no-dco`heading at:545`, so the anchor resolves. - The
scale-envelope.mdcitation fix is right:RankActionableIssuesnow starts atsrc/pkg/github/client.go:4780and its body ends at:4790, oldest-first within tier preserved.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Reviewed all feedback. The base-conflict request is already resolved on current head 7400da1, which includes current v5 at 9be2fee. The source citation/link failure is also fixed: relative links and anchors resolve, changelog-fragment-guard, and Sign-off survives the squash now pass. Both code-review comments confirm the wording and DCO routing are correct; no further changes requested. π Hive Agent: |
|
stage 095-pre-merge-soak β 060-reviewed: required-check-pending:Sign-off survives the squash |
|
Merged by hive contributor-lane auto-merge: CI green for β₯30m, reviewer verdict approve, @mendezr holds the trusted tier in this hive's contributor registry. |
β¦glyph on every gated row (#15084) * π Activity monitor: one merge-gate vocabulary and a labelled leading glyph on every gated row At 15:11 ET two Merge gate rows both read 'Ready for auto merge ⬑' while one carried a spinning glyph and the other none. The glyph was the agent-working cue (an agent's lastAction on that PR this round β the review swarm was re-reviewing #15042; nobody was on #15054), unlabelled, so it read as merge progress; and STAGE_TRACKER_ACTIVE_WORD mapped 060, 080 and 100 all to 'Ready for auto merge', so a 060 PR with CI still pending read as ready. - /api/stage-tracker PR items (and nested linked_prs) carry merge_gate {state, reason, sweep_running, last_sweep_at, next_sweep_at, soak_until, soak_remaining_seconds}; automerge gains a SweepClock that records the running pass (cause, targets) and the next floor time. - Pill words in pipeline order: Awaiting merge gate (what holds it) β Ready for auto merge (next sweep in Ns) β Soaking (time left) β Merging β Merged. Every gated row gets a leading glyph with the same sentence as title + aria-label; it spins while a sweep is on the PR, shows a clock while it waits; countdowns tick from the existing cue timer. - The agent-working spinner now carries 'Working now: <agent> β¦' as title + aria-label. - Legend in docs/dashboard-sections.md; node fixture tests on the captured #15042 / #15054 / #15044 payloads; Go tests for merge_gate. Fixes #15073 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * π± automerge: SweepClock unit test Signed-off-by: Andrew Anderson <andy@clubanderson.com> * π docs: resync api-reference citations after server.go line shift Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Summary
Fixes #15040
Verification
Not run (docs only; repository policy delegates tests and citation guards to CI). Compared the wording with the DCO routing reference,
dcoRequiredand its gated routing call, and the existing ungated-repository regression test inautomerge_stage_labels_test.go.β hive: backend=pi model=openai-codex/gpt-6.1-sol
π Hive Agent:
contributor| SHA:18e0dec0a