Skip to content

πŸ“– docs: clarify per-repo DCO routing at level 6 - #15044

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
mendezr:docs/15040-no-dco
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
mendezr:docs/15040-no-dco

Conversation

@mendezr

@mendezr mendezr commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Correct the L6 label row: DCO routing applies only where DCO is required, and follows author kind.
  • State that ungated repositories keep their lane stage and do not request a DCO rebase; link the detailed DCO rules.

Fixes #15040

Verification

Not run (docs only; repository policy delegates tests and citation guards to CI). Compared the wording with the DCO routing reference, dcoRequired and its gated routing call, and the existing ungated-repository regression test in automerge_stage_labels_test.go.

β€” hive: backend=pi model=openai-codex/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: 18e0dec0a

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • relative links and anchors resolve

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this against v5 rather than the diff alone; the new wording matches the code.

  • "routes by author kind: 070 (hive/self-authored), 071 (human), 072 (clanker)" β€” matches the stage table at src/docs/labels-and-control-signals.md:462 and the stageAuthorKind split in src/pkg/github/automerge/automerge_stage_labels.go:715 / :1135.
  • "Where DCO is required (detected … or configured via governor.labels.stage.dco.required)" β€” dcoRequired at automerge_stage_labels.go:666-676 consults the per-repo override first, then obs.Detail.DCOGate for the head; the key resolves to StageLabelsConfig.DCO (src/pkg/config/config.go:2706, yaml:"dco") β†’ StageDCOConfig.Required (:2760, yaml:"required").
  • The labels-and-control-signals.md#dco--no-dco--the-hive-owned-sign-off-signal anchor resolves to the heading at :545.
  • scale-envelope.md citation bump to client.go:4780-4790 is exact: RankActionableIssues spans src/pkg/github/client.go:4780-4790 on v5.

Looks correct to me; docs-only, no behaviour change.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak β†’ 060-reviewed: required-check-pending:Sign-off survives the squash

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14989 ✨ feat: let a sandboxed reviewer post reviews through a workspace spool same files src/docs/scale-envelope.md

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

Fixes hivecommons#15040

Hive-Run: hivecommons#15040
Hive-Plan: docs-currency DCO routing clarification
Hive-Spec: hivecommons#15040#ungated-repo-behavior
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-checked the new wording against the tree at 7400da1; it is accurate. Looks correct to me.

  • governor.labels.stage.dco.required exists (src/pkg/config/config.go:2750-2762, StageDCOConfig.Required), and its comment states the same per-repo gating this row now describes: labels written everywhere, stage routing and nudge only where DCO is required or detected.
  • The 070/071/072 split by author kind matches labels-and-control-signals.md:225-227 and the "The pair is mutually exclusive" paragraph at :559-566; the new [DCO routing] link targets the ### \dco` / `no-dco`heading at:545`, so the anchor resolves.
  • The scale-envelope.md citation fix is right: RankActionableIssues now starts at src/pkg/github/client.go:4780 and its body ends at :4790, oldest-first within tier preserved.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@mendezr

mendezr commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Reviewed all feedback. The base-conflict request is already resolved on current head 7400da1, which includes current v5 at 9be2fee. The source citation/link failure is also fixed: relative links and anchors resolve, changelog-fragment-guard, and Sign-off survives the squash now pass. Both code-review comments confirm the wording and DCO routing are correct; no further changes requested.


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak β†’ 060-reviewed: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit caaba9f into hivecommons:v5 Oct 28, 2026
86 of 96 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#150447400da1` sha256:56c9f60f152186723299d0019ac0735e276760eef667f2ecfa19eb7346586d52 β€” download from the dashboard or `hivectl review evidence #15044`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for β‰₯30m, reviewer verdict approve, @mendezr holds the trusted tier in this hive's contributor registry.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026
hivecommons-hive Bot pushed a commit that referenced this pull request Oct 28, 2026
…glyph on every gated row (#15084)

* πŸ› Activity monitor: one merge-gate vocabulary and a labelled leading glyph on every gated row

At 15:11 ET two Merge gate rows both read 'Ready for auto merge ⬑' while one
carried a spinning glyph and the other none. The glyph was the agent-working
cue (an agent's lastAction on that PR this round β€” the review swarm was
re-reviewing #15042; nobody was on #15054), unlabelled, so it read as merge
progress; and STAGE_TRACKER_ACTIVE_WORD mapped 060, 080 and 100 all to
'Ready for auto merge', so a 060 PR with CI still pending read as ready.

- /api/stage-tracker PR items (and nested linked_prs) carry
  merge_gate {state, reason, sweep_running, last_sweep_at, next_sweep_at,
  soak_until, soak_remaining_seconds}; automerge gains a SweepClock that
  records the running pass (cause, targets) and the next floor time.
- Pill words in pipeline order: Awaiting merge gate (what holds it) β†’
  Ready for auto merge (next sweep in Ns) β†’ Soaking (time left) β†’ Merging
  β†’ Merged. Every gated row gets a leading glyph with the same sentence as
  title + aria-label; it spins while a sweep is on the PR, shows a clock
  while it waits; countdowns tick from the existing cue timer.
- The agent-working spinner now carries 'Working now: <agent> …' as
  title + aria-label.
- Legend in docs/dashboard-sections.md; node fixture tests on the
  captured #15042 / #15054 / #15044 payloads; Go tests for merge_gate.

Fixes #15073

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 automerge: SweepClock unit test

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– docs: resync api-reference citations after server.go line shift

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (docs-currency): running-at-level-6.md says no-dco always carries the rebase command

1 participant