Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-15009.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- A busy hive whose reviewer lane is backed up no longer files a repeated unclassified runtime-error self-report for the one-shot "PR waits on the hive past the stage dwell" warning; the condition stays in the log and the dashboard's hive-held count ([#15009](https://github.com/hivecommons/hive/issues/15009)).
10 changes: 10 additions & 0 deletions src/pkg/fleetreport/fleetreport.go
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,16 @@ var benignSubstrings = []string{
// That is the merge-safety policy working as designed, re-logged per
// merge attempt, not a repeated runtime defect (hivecommons/hive#14727).
"forward-merge guard: refusing to squash",
// The stage labeller (src/pkg/github/automerge/automerge_stage_labels.go)
// warns once per PR per quiet period when a PR waiting on the hive
// (review pending, checks running) sits past its stage dwell, and
// surfaces the same condition as the dashboard's hive-held count
// (hivecommons/hive#12534). The feed keys on the message alone, so a
// busy hive whose reviewer lane is backed up has every held PR warn once
// and the burst across unrelated PRs reads as one repeated defect β€” it
// is a per-hive operational signal, not a runtime error
// (hivecommons/hive#15009).
"stage labels: pr waits on the hive past the stage dwell",
}

// IsBenignMessage reports whether a raw log message is noise the generic
Expand Down
9 changes: 9 additions & 0 deletions src/pkg/fleetreport/runtime_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,15 @@ func TestIsBenignMessageForwardMergeGuard(t *testing.T) {
}
}

func TestIsBenignMessageStageHiveHeld(t *testing.T) {
if !IsBenignMessage("stage labels: PR waits on the hive past the stage dwell β€” reviewer lane needs attention") {
t.Error("hive-held stage dwell warning not benign")
}
if IsBenignMessage("stage labels: provisioning failed") {
t.Error("stage label provisioning failure wrongly benign")
}
}

func TestIsBenignMessageCopilotModelFallback(t *testing.T) {
const msg = "copilot CLI substituted the configured model"
if !IsBenignMessage(msg) {
Expand Down
Loading