Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-review-watcher-abbreviated-head.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- The self-report classifier no longer files `unclassified_error_repeated` issues for the review-request watcher warning that an abbreviated verdict head is not the PR's current head and was recorded as written (#14997).
5 changes: 5 additions & 0 deletions src/pkg/fleetreport/fleetreport.go
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,11 @@ var benignSubstrings = []string{
// Request watchers log a policy denial (e.g. repo not allowlisted) as an
// expected outcome, not a runtime error.
"request watcher: denied (policy)",
// A reviewer's abbreviated verdict head that prefixes neither the dispatch
// head nor the PR's current head names an older revision; the relay keeps
// it as written on purpose (pkg/github/review_verdict_relay.go), so it is
// an expected outcome of a push landing mid-review, not a runtime defect.
"abbreviated verdict head is not the pr's current head; recorded as written",
// ReconcileSeededDefaults (pkg/policies/seed_reconcile.go) warns once per
// policy template whose on-disk copy diverges from the embedded default
// with no seed-manifest record, already deduped per path per process
Expand Down
1 change: 1 addition & 0 deletions src/pkg/fleetreport/runtime_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -994,6 +994,7 @@ func TestRecurringRuntimeMessagesAreClassified(t *testing.T) {
"issue-request watcher: DENIED (policy)",
"merge-request watcher: DENIED (policy)",
"pr-request watcher: DENIED (policy)",
"review-request watcher: abbreviated verdict head is not the PR's current head; recorded as written",
"push-branch-request watcher: DENIED (policy)",
} {
if !IsBenignMessage(m) {
Expand Down
Loading