Skip to content

📖 docs: refresh client.go line citations in labels-and-control-signals.md - #14918

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-14917
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-14917

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The cited client.go line ranges predate several refactors and no longer point at the symbols the sentences describe, so the docs-currency check and readers both land on unrelated code. Closes #14917

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14787 🐛 dco: re-home unsigned commits on adopted PRs so the gate can clear same files src/docs/labels-and-control-signals.md

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent alignment — the refresh resolves #14917 for the isHeld/IsHeldLabels/exempt/tracker/ranking citations (verified against src/pkg/github/client.go at 8effb19: isHeld 3434-3442, IsHeldLabels 4399-4401, HasExemptLabel 3575-3589, IsTrackerIssue 3634-3683, fetchIssues 1690-1899, fetchPRsWithDetails 1975-2165). Two citations in the hold row still don't land on the symbols the sentence names:

  1. src/docs/labels-and-control-signals.md:61 — "Built-in HoldLabels … (src/pkg/github/client.go:1317, …)". Line 1317 is var PermanentExemptLabels = []string{"do-not-merge"}; var HoldLabels is at client.go:1315. (1317 is correct where it is reused in the do-not-merge row at md:73.)
  2. src/docs/labels-and-control-signals.md:61 — "dashboard exact hold via Client.SetHoldLabels (… client.go:3314-3369)". That range is HasHoldLabel/HasHoldLabelWith/isHeld; func (c *Client) SetHoldLabels is at client.go:3394-3401. Suggest 3314-3401 (or cite 3394-3401 separately).

Both are one-token fixes in the same file; no scope creep otherwise — the diff touches only the citations the issue called out.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Docs-only; I verified every new citation against src/pkg/github/client.go at head 8effb19:

  • 1690-1899 = fetchIssues (hold → exempt/hard-suppress at 1798-1803 → require_labels at 1805); 1726-1744 = the standing-meta/advisory switch; 1975-2165 = fetchPRsWithDetails.
  • 1317 = PermanentExemptLabels; 3575-3589 = HasExemptLabel, and it does use EqualFold for equality but HasPrefix on the original string, as the "Exempt labels" bullet says.
  • 3314-3369 / 3318-3361 = HasHoldLabel / HasHoldLabelWith; 3434-3442 = Client.isHeld; 4399-4401 = Client.IsHeldLabels.
  • 3371-3380 = CanonicalHiveHoldLabel (hive-pause/<id>); 3386-3392 = HiveProvenanceLabel.
  • 3634-3683 = IsTrackerIssue; 4665-4679 / 4665-4698 = defaultActionablePriorityLabels (contains HumanAckLabel) and ActionablePriorityLabels; 4748-4777 = issueHasCheapHumanAcknowledgement.

On v5 the old ranges (e.g. 750-755, 1008-1024, 2745-2837) land on struct-field comments and observeIssueComment, so the refresh is real, not a no-op. python3 src/scripts/check-docs-citations.py src/docs at the PR head reports 1281 citations verified with no drift. No prose changed beyond the line numbers.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit f3c3dbd into v5 Oct 28, 2026
79 of 83 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-14917 branch October 28, 2026 12:23
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#149188effb19` sha256:0347a06c4508dc1c0a698738039e94f7693740fa973e90e16e15326da538f8f0 — download from the dashboard or `hivectl review evidence #14918`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (docs-currency): Pre-existing stale client.go line citations in labels-and-control-signals.md

0 participants