Skip to content

πŸ› deps: patch golang.org/x/net for GO-2026-6860 so govulncheck is green on v6 - #14753

Merged
hivecommons-hive[bot] merged 1 commit into
v6from
fix/v6-govulncheck
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v6from
fix/v6-govulncheck

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #14751

Summary

Bumps golang.org/x/net v0.61.0 β†’ v0.62.0 in src/go.mod to clear GO-2026-6860 (quadratic complexity coalescing text nodes in html, reached via connector.richHTMLToMarkdown β†’ html.ParseFragment). Regenerates go.sum and NOTICE, and adds a changelog.d/security-* fragment.

Forward-port of #14731 (already merged to v5; cherry-picked from 648ca07).

The red govulncheck check on v6 is holding every v6 PR at the auto-merge gate (base-branch-red:govulncheck).

Validation

  • go mod tidy β€” go.sum only changes for x/net
  • go build ./... β€” passes
  • No workflow changes required.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

…n v6

govulncheck fails on v6 because golang.org/x/net v0.61.0 is affected by
GO-2026-6860 (quadratic complexity coalescing text nodes in html;
reached via connector.richHTMLToMarkdown -> html.ParseFragment).
Bump to v0.62.0, regenerate go.sum and NOTICE. Forward-port of #14731
(cherry picked from commit 648ca07)

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot linked an issue Oct 28, 2026 that may be closed by this pull request
@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
8b14ae0

ℹ️ Sentinel notice β€” informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head 8b14ae0c4f25) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/go.mod

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit bdd285e into v6 Oct 28, 2026
80 of 83 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/v6-govulncheck branch October 28, 2026 01:04
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#147538b14ae0` sha256:1ae79901a0e6efdac1cdab2f84f02ef3adeadb9cfd5d348981ac9bbe771f891c β€” download from the dashboard or `hivectl review evidence #14753`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8b14ae0.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: govulncheck fails on v6 (GO-2026-6860)

1 participant