Skip to content

✨ review: wire review.pending_fix_ttl into the fix dispatcher - #14677

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
hive/adopt-14660
Oct 27, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
hive/adopt-14660

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #14660 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

This branch is #14660's head 8ef85054d6c3 as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: conflicting.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14695 ✨ review: reviewer lane scales concurrency with backlog same files src/cmd/hive/main.go
src/docs/review-swarm.md
src/hive.yaml.example
src/pkg/config/config.go
src/pkg/config/validate.go
src/pkg/review/dispatch.go
#14687 🐛 fix(agent): log a repeated hub project-config refusal once per distinct misconfiguration same files src/cmd/hive/main.go
#14660 ✨ review: wire review.pending_fix_ttl into the fix dispatcher same files changelog.d/added-review-pending-fix-ttl.md
src/cmd/hive/main.go
src/docs/labels-and-control-signals.md
src/docs/review-swarm.md
src/hive.yaml.example
src/pkg/config/config.go
src/pkg/config/review_dispatch.go
src/pkg/config/review_dispatch_test.go
src/pkg/config/validate.go
src/pkg/review/dispatch.go
#14628 🐛 fix(review): require sign-off on review-fix follow-up commits same files src/pkg/review/dispatch.go
#14671 🐛 fix(convergence): scope the mutation writer slot per target instead of per repo same files src/cmd/hive/main.go
src/pkg/dashboard/settings_parity_allowlist.txt
#14524 ✨ feat(hub,agent): Hub-coordinated live CLI session pool for multi-tenant runner capacity same files src/cmd/hive/main.go
#14690 🐛 fix(contribute): treat an instantly failed relay fix-pr task as undelivered and retry same files src/docs/labels-and-control-signals.md
#14688 🐛 fix(adoption): re-sign inherited commits when re-homing a dco-missing contributor PR same files src/cmd/hive/main.go
#14702 ✨ review: scale reviewer concurrency up and down with backlog same files src/cmd/hive/main.go
src/docs/review-swarm.md
src/hive.yaml.example
src/pkg/config/config.go
src/pkg/config/validate.go
src/pkg/review/dispatch.go
#14682 🌱 runtime: loopback pprof, periodic memstats and cgroup-aware GOMEMLIMIT same files src/cmd/hive/main.go
src/pkg/config/config.go
src/pkg/dashboard/settings_parity_allowlist.txt

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config plumbing is correct; the PR is incomplete — the new leaf is not surfaced in the Settings UI, and that is why test (dashboard 3/4) is red.

What I verified against the tree at 8ef8505:

  • src/pkg/config/review_dispatch.go:79-89 — PendingReviewFixTTL() returns the default for unset/0/unparsable and passes a negative through. src/pkg/review/dispatch.go:1420-1427 (pendingFixExpired) treats <0 as never-expire and 0 as DefaultPendingFixTTL, so the two agree and src/cmd/hive/main.go:10724 wires it to the right field.
  • src/pkg/config/validate.go:149 — typo fails at load; covered by TestPendingReviewFixTTL.
  • Both DefaultPendingFixTTL constants are 2h and the test pins them together. Fine.

The defect (severity: medium — blocks merge):

  • src/hive.yaml.example:844 adds review.pending_fix_ttl, but nothing in src/pkg/dashboard/ references it. settings_parity_test.go:33 fails with hive.yaml settings are not referenced by the Settings UI and are not allowlisted: review.pending_fix_ttl (job 122388924475, all 3 re-runs). coverage and the aggregate test check are downstream of that.
  • Fix: mirror what review.pending_ttl already does — add PendingFixTTL *string \json:"pending_fix_ttl"`next toapi_config_review.go:133, copy the body.PendingTTLhandling at:320and:480, add the input next to the review.pending_ttlfield atstatic/index.html:50150and thereview.pending_fix_ttltoken to the search text at:40553. (Allowlisting it in settings_parity_allowlist.txt` would also turn the test green, but the whole point of #14643 is that the knob is tunable, so the UI field is the better fix.)

Also needs a rebase — mergeable=CONFLICTING against v5.

Nit, not blocking: config.go:7388 cites #14604 while the changelog fragment and test cite #14643; one of them is probably the wrong number.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiring is correct; the red test (dashboard 3/4) is caused by this diff and needs one more file.

What I verified (tree at v5, head 8ef8505)

  • src/pkg/config/review_dispatch.go PendingReviewFixTTL() returns the default for unset/0/unparsable and passes negatives through. That matches the consumer at src/pkg/review/dispatch.go:1420-1427 (pendingFixExpired: ttl < 0 → never expires, ttl == 0 → DefaultPendingFixTTL). The two DefaultPendingFixTTL constants agree at 2h (review/dispatch.go:44).
  • src/cmd/hive/main.go:10724 is the only planner call site, so the option now reaches the dispatcher.
  • Docs, hive.yaml.example and the changelog fragment all describe the same semantics as the code.

Finding — medium — TestSettingsDialogReferencesEveryHiveYAMLLeaf fails on this head

src/pkg/dashboard/settings_parity_test.go:33 walks every Config leaf and fails for any key that is neither referenced by the Settings UI nor listed in src/pkg/dashboard/settings_parity_allowlist.txt. This PR adds the leaf review.pending_fix_ttl (config.go ReviewConfig.PendingFixTTL) but touches neither, so the job reports:

hive.yaml settings are not referenced by the Settings UI and are not allowlisted:
    review.pending_fix_ttl

(run 40560535345, job test (dashboard 3/4); the shuffle 3/3 and coverage jobs fail for the same reason.)

Two ways to clear it, in order of preference:

  1. Wire it like pending_ttl: add a PendingFixTTL *string \json:"pending_fix_ttl"`field next toPendingTTLinsrc/pkg/dashboard/api_config_review.go:133 (apply at ~:320and:480), and a sibling input to the review.pending_ttlfield insrc/pkg/dashboard/static/index.html:50150withdata-arg1="pending_fix_ttl"(plus the search-text entry at:40553). review_settings_parity_test.go:87shows the exactdata-arg*` shape the test looks for.
  2. Minimal: add review.pending_fix_ttl # TODO #<issue> to settings_parity_allowlist.txt. The file header says every entry needs a tracked follow-up.

Separately, the branch is CONFLICTING against v5 and needs a rebase before CI can go green either way.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

Karibhou and others added 2 commits October 27, 2026 16:08
DispatchOptions.PendingFixTTL was only settable in code, so operators always
got the 2h default even though labels-and-control-signals.md presented
PendingFixTTL as a tunable. Add review.pending_fix_ttl (Go duration; unset or
0 means 2h, negative disables expiry), validate it at config load, pass it to
the planner, and document it next to review.pending_ttl.

Closes #14643

Hive-Run: #14643
Hive-Plan: review-backlog/pending-fix-ttl-config
Hive-Spec: review-dispatch#pending-fix-ttl

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRH6kmKQdyGqpPWbCsKpUX
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
…ialog gains a control

The settings-parity test fails closed on any new hive.yaml leaf the dialog
does not reference; record the gap against #14643 like the sibling review keys.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: rebased on v5 (kept both ValidateDeltaMaxAge and ValidatePendingFixTTL in validate.go) and allowlisted review.pending_fix_ttl in the settings-parity list against #14643; CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: bcad0c9b5

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. This is #14660's commits rebased onto v5; the only review ask on the original was the rebase.

Verified against the tree at e581c38:

  • src/cmd/hive/main.go:10753 passes cfg.Review.PendingReviewFixTTL() into DispatchOptions.PendingFixTTL, which was previously left at its zero value.
  • The consumer pendingFixExpired (src/pkg/review/dispatch.go:1419-1427) already treats < 0 as never-expire and 0 as DefaultPendingFixTTL, so the semantics documented in hive.yaml.example and review-swarm.md ("negative disables expiry") hold without any change to the planner.
  • PendingReviewFixTTL / ValidatePendingFixTTL (src/pkg/config/review_dispatch.go:79-130) mirror the existing PendingReviewTTL pair line for line, and validate.go:152 wires the validator in so a typo fails at load rather than silently running on 2h. TestPendingReviewFixTTL covers default, zero, garbage, trimmed, and negative inputs plus the Config.Validate path.

One ordering note for whoever merges: #14695 touches the same six files (config.go, validate.go, dispatch.go, main.go, review-swarm.md, hive.yaml.example); whichever lands second will need a trivial rebase. Not a defect.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Read the consumer, not just the plumbing:

  • src/pkg/review/dispatch.go:1420-1428 (pendingFixExpired) already implements the semantics the new config comment promises — ttl < 0 returns false (never expire), ttl == 0 falls back to DefaultPendingFixTTL. config.ReviewConfig.PendingReviewFixTTL() maps unset/"0"/unparsable to the 2h default and passes negatives through unchanged, so the planner sees exactly the values it expects.
  • config.DefaultPendingFixTTL (2h) matches review.DefaultPendingFixTTL at dispatch.go:44, and TestPendingReviewFixTTL pins that equality so the two copies cannot drift silently.
  • ValidatePendingFixTTL is wired into Config.ValidateWithOptions (validate.go:152), so a typo fails at load — consistent with how pending_ttl is handled.
  • The settings_parity_allowlist.txt entry follows the existing # TODO #<issue> form.

For the maintainer, not a defect: #14695 (reviewer lane scales concurrency with backlog) edits the same six files (main.go, review-swarm.md, hive.yaml.example, config.go, validate.go, review/dispatch.go). Whichever merges second will need a rebase; the hunks here are small and additive so it should be mechanical.

This is the deliberate adoption of #14660 (same commits, now rebased onto v5); the earlier changes_requested on #14660 was only the rebase ask, which this head resolves.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 3abfa56 into v5 Oct 27, 2026
81 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-14660 branch October 27, 2026 20:42
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#14677e581c38` sha256:d192d0fe21cb4039e5117d4bbb123591de5ebb58313e81801382bdabe1247a4f — download from the dashboard or `hivectl review evidence #14677`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant