Repository navigation
🐛 fix(dashboard): keep tracker status pills on the row they describe - #14642
Conversation
The activity monitor drew the modifier chip and the since age in the title line's ghost strip (align-items: flex-start), so a wrapped title or an issue→PR row floated them to the top edge of the entry, where they read as the previous row's. The since text now closes the strip row, in line with the chevrons; the chip bottom-aligns in the title line so it sits directly over its own strip; entries get a hairline above and a whole-row hover tint. Fixes #14640 Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 68b963a. |
Fixes #14640
Root cause
stageTrackerHeadColsHtml(src/pkg/dashboard/static/index.html) rendered both the modifier chip (<li class="ham-seg cap"><span class="ham-badges">) and thesincetext into the title line's ghost strip (.ham-row-head), while the chevron strip sat in a separate.ham-strip-rowbelow with an emptyham-sincespacer. With.ham-row-head/.ham-head-cols .ham-seg { align-items: flex-start }, a two-line title or an issue→PR row (↳ #397+mainchip) pinned chip and age to the top edge of the row — and with no separator or hover surface between entries (onlypadding: var(--sp-5)) they read as the previous row's.Fix
sincemoves to the strip row:stageTrackerRowHtml/stageTrackerSubRowHtmlputstageTrackerSinceHtml(...)after the chevron<ol>; the title line keeps an empty spacer so the ghost strip's column widths are unchanged. The age is now exactly in line with the chevrons..ham-head-cols .ham-seg.cap { align-items: flex-end }): on a wrapped title it sits on the last line, directly over its own strip's cap, never up at the previous entry's edge. Multi-pill stacks (hold +1) unchanged. (Putting the chip on the strip line would either overlay the Merge gate / human-decision chevron or steal strip width per row and misalign the columns, so the chip stays in the title line, hugging the strip.).ham-row + .ham-rowhairline and a whole-row:hovertint (below.ham-selectedso selection still wins), spanning pill and age columns.sinceis shown (3em), the title-line spacer hidden, headersinceshown again so columns stay aligned; the chip cell spans the title grid.stageTrackerHeadColsHtmldrops its now-unusedsinceHtmlparameter.Tests
stage_tracker_ui_test.go(node-executed row renderer): asserts the since cell closes the strip row (afteraria-label="Pipeline progress"), the chip cell closes the title line immediately before its own.ham-strip-row, and chip + strip share one row container; sub-row since ordering flipped accordingly.Docs
src/docs/dashboard-sections.md: since column "in line with the chevron strip", chip placement + row fencing, and the stale "title lines never wrap" sentence (titles wrap since #13443) corrected. Changelog fragmentchangelog.d/fixed-tracker-pill-row-alignment.md.