Skip to content

🐛 fix(dashboard): keep tracker status pills on the row they describe - #14642

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-pill-alignment
Oct 27, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-pill-alignment

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #14640

Root cause

stageTrackerHeadColsHtml (src/pkg/dashboard/static/index.html) rendered both the modifier chip (<li class="ham-seg cap"><span class="ham-badges">) and the since text into the title line's ghost strip (.ham-row-head), while the chevron strip sat in a separate .ham-strip-row below with an empty ham-since spacer. With .ham-row-head / .ham-head-cols .ham-seg { align-items: flex-start }, a two-line title or an issue→PR row (↳ #397 + main chip) pinned chip and age to the top edge of the row — and with no separator or hover surface between entries (only padding: var(--sp-5)) they read as the previous row's.

Fix

  • since moves to the strip row: stageTrackerRowHtml / stageTrackerSubRowHtml put stageTrackerSinceHtml(...) after the chevron <ol>; the title line keeps an empty spacer so the ghost strip's column widths are unchanged. The age is now exactly in line with the chevrons.
  • Chip bottom-aligns in the title line (.ham-head-cols .ham-seg.cap { align-items: flex-end }): on a wrapped title it sits on the last line, directly over its own strip's cap, never up at the previous entry's edge. Multi-pill stacks (hold +1) unchanged. (Putting the chip on the strip line would either overlay the Merge gate / human-decision chevron or steal strip width per row and misalign the columns, so the chip stays in the title line, hugging the strip.)
  • Row fencing: .ham-row + .ham-row hairline and a whole-row :hover tint (below .ham-selected so selection still wins), spanning pill and age columns.
  • Compact (≤1100px): the strip-row since is shown (3em), the title-line spacer hidden, header since shown again so columns stay aligned; the chip cell spans the title grid.
  • stageTrackerHeadColsHtml drops its now-unused sinceHtml parameter.

Tests

stage_tracker_ui_test.go (node-executed row renderer): asserts the since cell closes the strip row (after aria-label="Pipeline progress"), the chip cell closes the title line immediately before its own .ham-strip-row, and chip + strip share one row container; sub-row since ordering flipped accordingly.

Docs

src/docs/dashboard-sections.md: since column "in line with the chevron strip", chip placement + row fencing, and the stale "title lines never wrap" sentence (titles wrap since #13443) corrected. Changelog fragment changelog.d/fixed-tracker-pill-row-alignment.md.

The activity monitor drew the modifier chip and the since age in the title
line's ghost strip (align-items: flex-start), so a wrapped title or an
issue→PR row floated them to the top edge of the entry, where they read as
the previous row's. The since text now closes the strip row, in line with
the chevrons; the chip bottom-aligns in the title line so it sits directly
over its own strip; entries get a hairline above and a whole-row hover tint.

Fixes #14640

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14617 ✨ RFC lifecycle notices to Discord #architecture-rfcs: opened, closed, taken off hold same files src/pkg/dashboard/static/index.html
#14573 ✨ feat(dashboard): show a draft pill in the activity tracker same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 90c7568 into v5 Oct 27, 2026
85 of 88 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-pill-alignment branch October 27, 2026 18:00
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#1464268b963a` sha256:b276715278c58e3a80da3f70fbdc6612c506d5b13b9d387a89bc31257d58f09c — download from the dashboard or `hivectl review evidence #14642`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 68b963a.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity monitor: status pill and since age float between rows when a row is tall

1 participant