[hivecommons-hive]

The stage tracker (activity monitor) now skips sidelined issues in the hive_advisory and dependency_dashboard buckets, so Dependency Dashboards and the Hive Advisory Report no longer appear as pipeline work or inflate counts, badge, chips and repo list. The Overview breakdown is unchanged, and renovate/dependabot PRs stay. Adds a test.

Closes #13257

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@Danathar

Closes #13299

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

[hivecommons-hive]

The change does what #13257 asks and is wired to the right bucket names; it leaves CI red because an existing test still encodes the old behaviour.

CI failure (test (rest 1/5), also pulling coverage and test red):

--- FAIL: TestStageTrackerListsSidelinedItems
    stage_tracker_cache_test.go:45: items = 13, want 14 (8 fixture + 4 parked issues + 2 sidelined PRs)

Mechanism: that test seeds NonActionableIssues with Number: 10, Title: "Advisory", Bucket: "hive_advisory" (src/pkg/dashboard/stage_tracker_cache_test.go:31) and asserts it is listed with issue10.Bucket == "hive_advisory" (:64) — exactly the row your new continue at src/pkg/dashboard/stage_tracker.go (inside the repo.NonActionableIssues loop) now drops. The old test pins the behaviour #13257 says is wrong, so it needs updating alongside: expect 13 items, drop the issue10 assertions, or assert #10 is absent.

Verified against the tree:

• The bucket strings are the ones the enumerator writes: src/pkg/github/client.go:1459 ("hive_advisory") and :1463 ("dependency_dashboard"); the new consts in ownership.go match them byte-for-byte.
• The skip is placed before the prNumbers//pull/ guard in the sidelined-issues loop only; the actionable/held frontendRepoIssues loop above is untouched, and client.go:1455-1465 sends standing meta issues only to details (never actionable/held), so no other path can re-admit them. Overview breakdown counters (overview_status.go:238-239) are not touched. Renovate PRs go through addPR, unaffected.
• The new TestStageTrackerSkipsStandingMetaIssues is sound.

Update TestStageTrackerListsSidelinedItems and this looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the diff against v6 plus the bucket producer and the tracker loop. The behaviour change is correct and minimal; what blocks it is a pre-existing test the PR invalidates without updating.

1. TestStageTrackerListsSidelinedItems now fails deterministically (medium, blocks merge)

src/pkg/dashboard/stage_tracker_cache_test.go:31 seeds NonActionableIssues with {Number: 10, Title: "Advisory", Bucket: "hive_advisory"} and line 45 asserts len(resp.Items) == 14. With the new continue at src/pkg/dashboard/stage_tracker.go:812 that issue is intentionally dropped, so the count is 13. CI confirms on test (rest 1/5), test (dashboard shuffle 1/2) and coverage:

stage_tracker_cache_test.go:45: items = 13, want 14 (8 fixture + 4 parked issues + 2 sidelined PRs)
--- FAIL: TestStageTrackerListsSidelinedItems

This is the right behaviour per #13257 — the old test encoded the bug — so the fix is to update that fixture's expectation (13 items, and assert issue 10 is absent) rather than to change the code. Also worth refreshing the doc comment at stage_tracker.go:100-101, which still lists hive_advisory among the buckets a tracker item can carry.

Verified correct

• The two bucket strings match what the producer emits: src/pkg/github/client.go:1459 ("hive_advisory") and :1463 ("dependency_dashboard"). The frontend uses the same keys (index.html:17851, 17854).
• The skip sits before addIssue, so these issues never reach the items slice and therefore drop out of counts, badge, chips and the repo facet list without further changes — matching the body.
• NonActionablePrs is untouched, so renovate/dependabot PRs still list, as the new test asserts (stage_tracker_test.go:522).
• Overview breakdown path (overview_status.go:238-239) is a separate consumer and unaffected.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me.

• The two new constants in src/pkg/dashboard/ownership.go:149-150 match the strings the producer actually emits: src/pkg/github/client.go:1459 ("hive_advisory") and :1463 ("dependency_dashboard"), and the same strings overview_status.go:238-239 already keys the breakdown on — so the overview count is unchanged while the monitor drops them.
• The skip sits in the repo.NonActionableIssues loop (stage_tracker.go:812), which is where workIssue routes these buckets; the ActionableIssues path is untouched, so a plain issue still lists.
• TestStageTrackerSkipsStandingMetaIssues covers both buckets plus a renovate PR staying listed, and the existing fixture test was adjusted (14 → 13) rather than loosened.

No findings. I have not approved anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me (not an approval — a human still signs).

Read the producer and the only consumer path at head c89b05d:

• pkg/github/client.go:1456-1465 — standingMetaIssueKindFor classifies these issues and continues before the hold/actionable split, so they can only ever reach the tracker as work details in repo.NonActionableIssues with bucket "hive_advisory" / "dependency_dashboard". The frontendRepoIssues path at stage_tracker.go:796-801 cannot see them, so the single skip at stage_tracker.go:812 is sufficient — no second filter needed on the actionable loop.
• The new constants in ownership.go:149-150 match the producer's literals exactly (client.go:1459,1463) and the Overview breakdown keys (overview_status.go:238-239), so the Overview counts are untouched, as #13257 asks.
• TestStageTrackerSkipsStandingMetaIssues covers the one thing worth guarding: a renovate[bot] PR (#30) still appears while the Dependency Dashboard issue (#20) does not.

Implements the first of the two approaches #13257 proposed; the alternative (re-running the predicate on every issue path) would be redundant given the producer already excludes them upstream.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Hive filed review findings that do not block this PR as backlog items:

• Review backlog (style): Formal escalation model still enumerates three verdict classes #13253 — Review backlog (style): overview_status.go uses bare bucket string literals the new constants now name (Review backlog (style): Formal escalation model still enumerates three verdict classes #13253)

Cap: 10 backlog item(s) per PR per day.

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the path at f21ac28. Looks correct to me.

• src/pkg/github/client.go:1466-1474: standing meta issues are classified before the actionability buckets and emitted via workIssue(..., "hive_advisory", …) / "dependency_dashboard", which sets RepoWorkIssue.Bucket verbatim (client.go:4041). They can only reach the tracker through NonActionableIssues, so the single continue in buildStageTracker (stage_tracker.go:812) is the one place that needs it.
• Replacing the two string literals in overview_status.go with the new ownership.go constants keeps the Overview breakdown byte-identical ("hive_advisory" / "dependency_dashboard"), so the overview counts are unchanged as the body states.

One docs nit (not blocking): src/docs/dashboard.md still says "The list is complete: every open issue and PR of the watched repos is an entry — …" immediately before the new sentence that excludes standing meta issues. Worth softening the first sentence so the paragraph doesn't contradict itself.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

hive/awaiting-ci: rebased onto v6 (one doc-line conflict in src/docs/dashboard-sections.md merged — v6's needs-triage note kept alongside this PR's standing-meta exclusion). CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the tree around the change: this looks correct to me.

• The only emitter of the hive_advisory / dependency_dashboard buckets is src/pkg/github/client.go:1466-1475, which continues before hold/exempt handling, so those issues only ever reach the dashboard via repo.NonActionableIssues. The new skip at src/pkg/dashboard/stage_tracker.go:817-819 sits on exactly that loop, before addIssue, so there is no second path that could still list them.
• buildStageTracker builds items only from the status snapshot (no stage-store-only rows), so a stale stage/* record on one of these issues cannot resurrect it.
• The new constants in ownership.go:154-155 match the literal strings in client.go, and overview_status.go keeps counting them in the Overview breakdown as the docs now say (dashboard.md:808, dashboard-sections.md:615).

Test adjustments (14 → 13 items, new TestStageTrackerSkipsStandingMetaIssues) match the behaviour. No findings.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the v6 tree around the change. The fix is correct and narrowly scoped:

• src/pkg/github/client.go:1466-1475 is the only producer of the hive_advisory / dependency_dashboard buckets: standing meta issues are counted in the breakdown and appended to the work details with those literal bucket names, then continue — so they never reach the actionable set and only enter the tracker through repo.NonActionableIssues.
• src/pkg/dashboard/stage_tracker.go:814-822 is the only path that turns NonActionableIssues into tracker rows; buildStageTracker has no other issue source (the frontendRepoIssues loop is the actionable set). The new continue therefore removes exactly these two buckets and nothing else; renovate/dependabot PRs go through NonActionablePrs / frontendRepoPRs and are untouched, as the body says.
• The new constants in ownership.go:152-155 equal the literals in pkg/github/client.go:1469,1473, and overview_status.go:238-239,557-558 are pure literal→constant swaps, so the Overview breakdown is unchanged.
• The test update (14→13 items, advisory absent) matches the behaviour.

One small, non-blocking observation: the bucket names are now constants in pkg/dashboard but still string literals in pkg/github/client.go:1469,1473 (and in the RepoWorkBreakdown json tags at client.go:4073-4074). A future rename on either side would silently stop the skip from matching. Not a defect today — just worth keeping in mind if these ever move.

Body matches the diff. Looks correct to me.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#13261c0502e8` sha256:2bfd1da2e8fb21be62afdb3d6915c39d35abb26423ecd198dd425e567dd5fca9 — download from the dashboard or `hivectl review evidence #13261`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback