Repository navigation
🐛 hub: don't group hives 100+ commits behind under "Up to date" - #12475
Conversation
The upgrade-state grouper mapped every '' state (no rollout in flight, nothing queued) to "Up to date", so six hives reading 107–161 behind sat under an "Up to date (6)" header. Split on commitsBehindTarget into a "Behind target (no upgrade pending)" group. Part of #12466 Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Changelog fragment in the wrong directoryFragments live in git mv src/changelog.d/fixed-hub-upgrade-group-behind.md changelog.d/fixed-hub-upgrade-group-behind.md
git commit -s -m "changelog: move fragment to repo-root changelog.d/"See |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
A different merged PR closed the claimed issue. Leaving this contributor PR open for a human to review. This comment is edited in place by the supersession sweep; it is not duplicated. |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 33a6f35. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Part of #12466 (the separate "Up to date (6)" mislabel noted there). Siblings: #12472 (spoke loop), #12474 (×0 badge).
Problem
Grouping /dashboard by Upgrade state showed an "Up to date (6)" header over six hives whose rows each read "107–161 behind".
hiveUpgradeStatereturns''for "no rollout in flight and nothing queued", and the grouper mapped every''to "Up to date" — including hives far behind with auto-upgrade off or whose tracked channel has not promoted.Fix
hiveUpgradeGroupLabel(h)(the dimension'sof()now delegates to it): queued → upgrading →Behind target (no upgrade pending)whencommitsBehindTarget > 0→ Up to date.HIVE_UPGRADE_GROUP_BEHINDconstant;_upgradeGroupOrdersorts it between Upgrading and Up to date; unknown labels still last.hiveUpgradeStateitself is unchanged, so the filter pills / facet counts / row badges keep their contract.Tests
TestUpgradeGroupLabelSplitsBehindFromUpToDate(node harness on the real JS: current / behind+off / behind as string / queued / upgrading, plus sort order) andTestUpgradeGroupDimensionUsesNamedLabeler.go test ./pkg/hub/... ./pkg/dashboard/... -count=1green; no new inlinestyle=.Per RFC #12062: display-only; nothing reads or changes merge eligibility. cc @mrbobbytables