Skip to content

🐛 hub: don't group hives 100+ commits behind under "Up to date" - #12475

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/hub-upgrade-group-behind
Oct 16, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/hub-upgrade-group-behind

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Part of #12466 (the separate "Up to date (6)" mislabel noted there). Siblings: #12472 (spoke loop), #12474 (×0 badge).

Problem

Grouping /dashboard by Upgrade state showed an "Up to date (6)" header over six hives whose rows each read "107–161 behind". hiveUpgradeState returns '' for "no rollout in flight and nothing queued", and the grouper mapped every '' to "Up to date" — including hives far behind with auto-upgrade off or whose tracked channel has not promoted.

Fix

  • New named grouper hiveUpgradeGroupLabel(h) (the dimension's of() now delegates to it): queued → upgrading → Behind target (no upgrade pending) when commitsBehindTarget > 0 → Up to date.
  • New HIVE_UPGRADE_GROUP_BEHIND constant; _upgradeGroupOrder sorts it between Upgrading and Up to date; unknown labels still last.
  • hiveUpgradeState itself is unchanged, so the filter pills / facet counts / row badges keep their contract.

Tests

  • TestUpgradeGroupLabelSplitsBehindFromUpToDate (node harness on the real JS: current / behind+off / behind as string / queued / upgrading, plus sort order) and TestUpgradeGroupDimensionUsesNamedLabeler.
  • go test ./pkg/hub/... ./pkg/dashboard/... -count=1 green; no new inline style=.

Per RFC #12062: display-only; nothing reads or changes merge eligibility. cc @mrbobbytables

The upgrade-state grouper mapped every '' state (no rollout in flight,
nothing queued) to "Up to date", so six hives reading 107–161 behind sat
under an "Up to date (6)" header. Split on commitsBehindTarget into a
"Behind target (no upgrade pending)" group.

Part of #12466

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Changelog fragment in the wrong directory

Fragments live in changelog.d/ at the repository root, not under src/. Files under src/changelog.d/ are never compiled into CHANGELOG.md, so the changelog-fragment-guard check fails. Move them and push:

git mv src/changelog.d/fixed-hub-upgrade-group-behind.md changelog.d/fixed-hub-upgrade-group-behind.md
git commit -s -m "changelog: move fragment to repo-root changelog.d/"

See changelog.d/README.md (#5675, #11919). This comment is removed automatically once nothing is misplaced.

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#12471 ✨ hub: explain evidence-driven Fleet quadrant scores same files src/pkg/hub/assets/dashboard.html
#12428 ✨ evidence: emit revert rates by author kind for the hub drill-down same files src/pkg/hub/assets/dashboard.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: hive#12466
  • Closing PR: #12472

A different merged PR closed the claimed issue. Leaving this contributor PR open for a human to review.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive
hivecommons-hive Bot merged commit 84ef21e into v5 Oct 16, 2026
67 of 70 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 33a6f35.

@kubestellar-prow
kubestellar-prow Bot deleted the fix/hub-upgrade-group-behind branch October 16, 2026 17:02
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant