Skip to content

test(dashboard): fix string quoting in throughput-sla SLA tile test - #12088

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-12085-sla-test-syntax
Oct 15, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-12085-sla-test-syntax

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Refs #12085 (needs-human: #12086 is the maintainer's fix but is DIRTY against v5 after #12084 landed; this minimal 2-line syntax fix unblocks the baseline — close whichever lands second)

Problem

server-tests is red on v5 HEAD (e59e627, run 38769872799) and therefore on every open v5 PR. #12084 fixed the span-by-index selection but wrapped the vm.runInContext source in single quotes while the span-key literals ('start_to_pr', 'pr_to_merge') also use single quotes, so dashboard/test/throughput-sla.test.js fails to parse:

dashboard/test/throughput-sla.test.js:100
  const html = vm.runInContext('prtSLATile(PRT_SLA_SPANS.find(s => s.key === 'start_to_pr'), ...
SyntaxError: missing ) after argument list

Fix

Use double quotes for the outer string on both calls (lines 100 and 110), matching what #12086 does. node --check passes on the file. Test-only change, no changelog fragment (same as #12084).

Unblocks #12051 and the other v5 PRs red on server-tests.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

#12084 switched the SLA tile test to select spans by key but wrapped the
vm.runInContext source in single quotes while the key literals also use
single quotes, so the file fails to parse (SyntaxError: missing ) after
argument list) and the server-tests job is red on every v5 PR.

Use double quotes for the outer string on both calls.

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#12086 🐛 dashboard tests: select SLA spans by key, not index same files dashboard/test/throughput-sla.test.js

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit a528c41 into v5 Oct 15, 2026
57 of 59 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-12085-sla-test-syntax branch October 15, 2026 16:45
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants