Repository navigation
test(dashboard): fix string quoting in throughput-sla SLA tile test - #12088
Conversation
#12084 switched the SLA tile test to select spans by key but wrapped the vm.runInContext source in single quotes while the key literals also use single quotes, so the file fails to parse (SyntaxError: missing ) after argument list) and the server-tests job is red on every v5 PR. Use double quotes for the outer string on both calls. Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Refs #12085 (needs-human: #12086 is the maintainer's fix but is DIRTY against v5 after #12084 landed; this minimal 2-line syntax fix unblocks the baseline — close whichever lands second)
Problem
server-testsis red onv5HEAD (e59e627, run 38769872799) and therefore on every open v5 PR. #12084 fixed the span-by-index selection but wrapped thevm.runInContextsource in single quotes while the span-key literals ('start_to_pr','pr_to_merge') also use single quotes, sodashboard/test/throughput-sla.test.jsfails to parse:Fix
Use double quotes for the outer string on both calls (lines 100 and 110), matching what #12086 does.
node --checkpasses on the file. Test-only change, no changelog fragment (same as #12084).Unblocks #12051 and the other v5 PRs red on
server-tests.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson