Repository navigation
🐛 hub: fix fleet Version column — stable "N behind · building", "—" versions, upgrade control - #11647
Conversation
…ersions, upgrade control Fixes #11645 Stable hives sitting exactly at the auto-promoted stable commit rendered "796 behind · building" with an hourglass and no upgrade control, while being grouped under "Up to date". Three defects, one column: 1. activeReleaseLine fell back to the highest-numbered line (v6) once auto-promotion held :stable off any branch tip (Branch == ""), so commitsBehindStableV4 for every hive was measured against the v6 tip. The stable line now follows the channel stable is promoted from (stable → candidate → edge) and my-hives measures each hive against its own branch tip (new branchTipSHA field). 2. channelPublishedImageTarget walked the branch forward for :stable too, handing stable spokes newer v5 per-SHA images (3910932, 9c1a585, 6eed1b9 in recentEvents) and bypassing the soak. :stable is now promotion-gated: target == channel commit, PromotionGated=true, never VerificationUnavailable. The dashboard uses that flag to stop the candidate build status leaking into stable rows and notes the stable-vs-candidate lag in the ✓ tooltip instead. 3. The Version cell rendered "—" for hives with no reported version. my-hives now sends versionMissingReason ("no heartbeat yet", "push-only cluster · awaiting spoke heartbeat", "heartbeat carries no version") and the cell appends "last seen <age>" so no-data and stale-data read differently. The upgrade control is emitted from one attribute source for the auto and manual paths; while the target image is still building it stays visible but aria-disabled with the tooltip "image for <sha> still building". Signed-off-by: Andrew Anderson <andy@clubanderson.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
Keeps the hub static-pages style= count at the 947 ratchet baseline. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 476e7eb. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #11645
What
Three fleet-page (My Hives) Version-column defects seen live on 2026-10-12 (hub
3d0503c, 97 hives)::stablehives at0d399a6(== channel commit) badge "796 behind · building" ⏳, grouped "Up to date"image_pulls.goactiveReleaseLine: stableBranch==""after auto-promotion → fallback to highest line v6;commitsBehindStableV4measured vs v6 tip.dashboard.htmlchannelImagePendingfired becausebehindTargetSHA != _latestSHAs[v5], pulling_latestImageStatus.v5("building") into stable rows.channelUpstream(stable→candidate→edge ⇒ v5); my-hives measures each hive vs its own branch tip (branchTipSHA); newbehindTargetPromotionGatedflag gateschannelImagePending; ✓ tooltip carries "stable channel is N behind candidate".:stablespokes to3910932/9c1a585/6eed1b9(recentEvents)channel_image_target.gowalked the branch forward for:stabletoo →reachableUpgradeTargetbypassed the soak:stableis promotion-gated: target == channel commit, no walk,PromotionGated=true, neverVerificationUnavailableGitHash/Version(30 never heartbeated this epoch, 6 last seen 17:02Z); UI printed "—"versionMissingReason("no heartbeat yet" / "push-only cluster · awaiting spoke heartbeat" / "heartbeat carries no version") + "last seen " in the cell and an explanatory tooltipisCurrent; enabled-with-hint while target image buildingaria-disabled+ tooltip "image for still building" while buildingTests
go test ./pkg/hub/... -cover→ok 88.5%(floor 87%).fleet_version_column_test.go: promotion-gated stable target (blocking + non-blocking),reachableUpgradeTargetfor stable,channelFollowsBranchTip,activeReleaseLineupstream walk,versionMissingReason,clusterIsPullOnly, dashboard markup contract.Not in this PR (operator)
vllm-d spokes are all
CreateContainerError(SELinux relabel of the CephFS PVC fails on/data/.hive) andHIVE_CLUSTER_ID(#11432) is still unset there — tracked in the issue.