Skip to content

πŸ› Hub: keep channel target probes off my-hives - #11439

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
perf/hub-my-hives-dominant-cost
Oct 10, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
perf/hub-my-hives-dominant-cost

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Follow-up to #11429. Fixes #11427.

Summary

  • removes the dominant /api/saas/my-hives request-path stall: per-row release-channel target resolution no longer runs synchronous GitHub commit-list + GHCR manifest probes from behindTargetFor
  • serves cached channel image targets immediately and refreshes stale/missing targets in one background goroutine per (branch, channel, floating SHA)
  • keeps active per-user my-hives snapshots refreshed every 5s in the background, independent of browser polling, so return loads use a warm snapshot

Evidence

Live hub logs during the slow window were dominated by GitHub commit-list timeouts, e.g. SHA poll: commit list request failed ... context deadline exceeded. The synchronous path was handleMyHives -> behindTargetFor -> channelPublishedImageTarget -> listChannelBranchCommits / probeSpokeImageTag, once for release-channel hives.

Validation

  • gofmt -l src/pkg/hub/behind_target.go src/pkg/hub/channel_image_target.go src/pkg/hub/saas_hives_api.go src/pkg/hub/server.go
  • git diff --check
  • bash src/scripts/check-api-reference-citations.sh --fix (no drift)

Per AGENTS.md, CI is the Go test/coverage/vet verdict.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 10, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the perf/hub-my-hives-dominant-cost branch from bdc59b6 to d67ee73 Compare October 10, 2026 14:41
@hivecommons-hive
hivecommons-hive Bot merged commit c1732b1 into v5 Oct 10, 2026
65 of 66 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at d67ee73.

@kubestellar-prow
kubestellar-prow Bot deleted the perf/hub-my-hives-dominant-cost branch October 10, 2026 14:54
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Hub fleet page: 'Loading your hives' spinner lingers; /api/saas/my-hives slow

1 participant