Repository navigation
π fix(ci): repair v6 baseline β merge_strategy test fixture and api-reference citations - #10900
Conversation
β¦eference citations TestInvalidMergeStrategyFailsValidationAndStopsAutoMerge (added in #10893) built a Config with no agents, so Validate() stopped at 'at least one agent must be configured' before reaching the merge_strategy check it asserts on. Give the fixture one agent so the merge_strategy error is the first failure. Lines registered in pkg/dashboard/api.go shifted under #10893/#10894, drifting 102 citations in docs/api-reference.md; regenerated with scripts/check-api-reference-citations.sh --fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #10899
Repairs the two red checks on the v6 default branch so sibling PRs (#10895, #10897) stop inheriting them.
pkg/config/repo_merge_strategy_test.go:TestInvalidMergeStrategyFailsValidationAndStopsAutoMerge(from β¨ config: per-repo merge_strategy (direct | hive-serialized)Β #10893) built aConfigwith no agents, soValidate()returnedat least one agent must be configuredbefore reaching the merge_strategy check it asserts on. The fixture now declares one agent.docs/api-reference.md: 102pkg/dashboard/api.go:<line>citations drifted after β¨ config: per-repo merge_strategy (direct | hive-serialized)Β #10893/β¨ github: lane-only branch-rules reader (ruleset required checks)Β #10894 shifted route registrations; regenerated withscripts/check-api-reference-citations.sh --fix(0 unresolved).No user-visible
src/behaviour change (test + docs only), so no changelog fragment.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88