Skip to content

🐛 dashboard: Overview 'Actionable now' shows the exact reconciling equation; drop median-age tile - #10697

Merged
clubanderson merged 3 commits into
v5from
fix/overview-actionable-math
Oct 5, 2026
Merged

clubanderson merged 3 commits into
v5from
fix/overview-actionable-math

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • move the Overview reconciliation text onto the Actionable now KPI as a server-provided equation
  • add the same server-side reconciliation to Governor actionable issues and actionable PRs
  • remove explanatory subtitles from Total open issues / Total open PRs
  • remove the Overview median actionable age KPI, history field, age-basis setting, and docs references
  • keep Held and Blocked / needs-human driven by the same server-side partition terms

Partition

For the owner screenshot, the shared partition is:

41 issues + 17 PRs = 13 actionable + 13 held + 10 blocked/needs-human + 22 outside

The 22 outside items are the scanner-filtered issue buckets shown previously under Total open issues: 5 needs-direction, 2 needs-decision, 1 exempt, 8 reporter triage, 1 hive advisory, plus the remaining outside issue filters. Needs-human items suppressed outside the Overview bands are folded into the blocked/needs-human term before the outside term is computed.

Governor now derives its two headline tiles from the same partition: issues reconcile as open − held − blocked/needs-human − confirm/close − outside/other = actionable issues; PRs reconcile as open − held − blocked/needs-human − draft − outside/other = actionable PRs. The test fixture asserts Overview Actionable now equals Governor actionable issues plus Governor actionable PRs by construction.

Tests

  • gofmt -l pkg/dashboard/server.go pkg/dashboard/overview_status.go pkg/dashboard/overview_totals_10629_test.go pkg/dashboard/overview_kpi_sparklines_test.go pkg/dashboard/overview_kpi_values_10139_test.go pkg/dashboard/actionable_now_10561_test.go
  • go vet ./pkg/dashboard/...
  • go test ./pkg/dashboard/... -short -count=1
  • go test ./pkg/dashboard/webstatic -short -count=1
  • bash scripts/check-api-reference-citations.sh

Closes #10656.
Refs #10561.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2026
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson force-pushed the fix/overview-actionable-math branch from 3a4a90c to 2e150ba Compare October 5, 2026 19:48
@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2026
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: hive#10656
  • Closing PR: #10658

A different merged PR closed the claimed issue. Leaving this contributor PR open for a human to review.

This comment is edited in place by the supersession sweep; it is not duplicated.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/overview-actionable-math branch from 224d414 to b02f4f6 Compare October 5, 2026 20:01
clubanderson and others added 2 commits October 5, 2026 20:01
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson merged commit 1979b68 into v5 Oct 5, 2026
46 of 47 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/overview-actionable-math branch October 5, 2026 20:09
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10696 fix(feedback): never @-mention a self-reported submitter login same files src/pkg/dashboard/static/index.html
#10695 ✨ dashboard: sticky navbar with centered agent cards and UP NEXT motion same files src/pkg/dashboard/static/index.html
#10699 ✨ dashboard: show fact-count sparkline in collapsed Knowledge header same files src/pkg/dashboard/static/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 dashboard: Overview 'Median age' KPI doesn't say what it measures (confused with MTTR)

1 participant