Skip to content

πŸ› No-dco repair kick makes agents sign off commits someone else wroteΒ #19267

Closed

Description

@clubanderson

What happens

When a PR is labelled no-dco and its CI is red, the FIX-BEFORE-NEW re-engagement kick (redPRFixKick, src/cmd/hive/main_sweeps.go) tells the agent:

gh pr checkout N --repo R β†’ git rebase --signoff <base> (original authors preserved) β†’ git push --force-with-lease

git rebase --signoff appends the agent's own bot Signed-off-by to every commit in the range, including commits a person wrote. That breaks the "Sign-off survives the squash" check, and a bot trailer under a person's commit is not a sign-off the bot can give. It happened on #19102 (commit e7fc580: authored by a person, committed by the scanner lane, with both trailers).

Fix

  • The kick tells the agent to sign off only the commits it authored: git rebase <base> --exec that amends with --signoff only when the commit's author email is the agent's own lane identity, and to leave anyone else's commits alone and ask their author on the PR.
  • The sandbox push broker (src/crux/pushbroker) already refuses a lane Signed-off-by on a commit authored or committed by another identity; its refusal now says why and what to do instead, and new tests pin the πŸ› Let the agent that opened a PR reply on its review threadsΒ #19102 shape on a leased push (refused, nothing pushed) and that the lane's own signed commits still push beside an untouched author's commit.
  • Docs (stage labels DCO section, sandbox isolation) and a changelog fragment.

Activity

  1. self-assigned this
    on Nov 19, 2026
  2. clubanderson commented on Nov 19, 2026

    @clubanderson
    MemberAuthor

    Claiming: working on this now, PR to follow.

  3. clubanderson commented on Nov 19, 2026

    @clubanderson
    MemberAuthor

    PR: #19268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions