Skip to content

[scanner] Review-rule classifier ignores quotes, code fences and questions; broaden going-forward phrases #19137

Closed

Description

@hivecommons-hive

Part of #19135.

In src/pkg/reviewrules/classify.go, Classify matches the whole body. Make it ignore quoted (>) lines, fenced code and questions, and fall back to the whole comment when the rule sentence is too short to stand alone. Broaden going-forward to future assessments/analyses/reviews/work, for the future, moving forward. Table tests for each case and a changelog fragment.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 18, 2026
  2. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (covering PR merged or closed).

    Claim history
    • 2026-11-18 21:17 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 21:57 UTC — released by scanner (agent; covering PR merged or closed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions