Skip to content

🐛 Pinned reviewer rules skip keyword-less kicks, and the review-rules channel needs a restart when created on first capture #19094

Closed

Description

@clubanderson

Follow-up to #19046 (PR #19086).

Gaps

  1. The scheduler's kick primer returns before the knowledge primer runs when a kick has no issues or no extractable keywords. Pinned, scope-matching reviewer rules (tag pin) are meant to load whatever the kick's keywords are, so for those kicks they never load.
  2. The review-rules channel is connected and registered with the primer only at boot, and only when it or its parent directory exists. On a host without the vaults directory the channel is created on the first capture, but its rules are not primed (and the dashboard does not list it) until the next restart. The docs describe this imprecisely.

Expected

  • A kick with no extractable keywords still receives pinned rules whose scope admits it. Ranked knowledge behavior is unchanged.
  • When the channel directory does not exist at boot, the primer registers it by path and opens it the first time it exists, connecting it to the knowledge API then, so rules captured after boot are primed and listed without a restart.
  • Docs match the code; tests for both.

Activity

  1. clubanderson commented on Nov 18, 2026

    @clubanderson
    MemberAuthor

    /claim

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions