Skip to content

[scanner] ✨ Review-feedback sweep captures reviewer-stated rules into the knowledge store and checks the reply #19048

Closed

Description

@hivecommons-hive

Child of #19046 (part 1 of 3). Builds on the review-feedback sweep in #19029 (src/pkg/reviewfeedback/, src/cmd/hive/review_feedback_wire.go), which is not on v5 yet.

Gap

When a reviewer states a rule or source of truth for future assessments, the sweep's kick only tells the agent to run hivectl knowledge create. Nothing records the rule if the agent skips it, and nothing checks the reply mentions it.

Expected

  • A first-class capture path in the sweep: a stated rule is written to the hive's knowledge store (see src/docs/knowledge-entries.md) with the PR comment URL/id as its source, idempotent per comment id.
  • After the agent replies, the sweep checks the reply references the captured entry; if not, it logs and raises a needs-human note.
  • Unit tests for the capture (idempotency, source field) and the reply check.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 18, 2026
  2. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-18 17:55 UTC — claimed by Danathar (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 17:59 UTC — released by Danathar (contributor; lease revoked)
    • 2026-11-18 19:39 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 20:06 UTC — released by scanner (agent; holding agent relaunched)
  3. added
    stage/020-claimedClaimed by the scanner or a relay contributor
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    stage/020-claimedClaimed by the scanner or a relay contributor
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 18, 2026
  4. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: the blocked label was applied by the hive without a blocked-on marker, so nothing could lift it. This issue is actionable again.

  5. clubanderson commented on Nov 18, 2026

    @clubanderson
    Member

    Covered by #19086 (merged as 9312e1b): reviewer-stated rules are captured deterministically into the hive's review-rules knowledge channel with the source comment as provenance, idempotent per comment id, and a rule whose home is another project's repo gets exactly one needs-human note carrying the proposed text (tests: TestReviewFeedbackSweep_RuleCaptureIsIdempotent, TestReviewFeedbackSweep_ForeignRepoRuleGetsOneProposalNote). The sweep itself posts the "Recorded as rule R-n" reply, so a separate check that the agent's reply mentions the entry is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions