You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[scanner] ✨ Review-feedback sweep captures reviewer-stated rules into the knowledge store and checks the reply #19048
Child of #19046 (part 1 of 3). Builds on the review-feedback sweep in #19029 (src/pkg/reviewfeedback/, src/cmd/hive/review_feedback_wire.go), which is not on v5 yet.
Gap
When a reviewer states a rule or source of truth for future assessments, the sweep's kick only tells the agent to run hivectl knowledge create. Nothing records the rule if the agent skips it, and nothing checks the reply mentions it.
Expected
A first-class capture path in the sweep: a stated rule is written to the hive's knowledge store (see src/docs/knowledge-entries.md) with the PR comment URL/id as its source, idempotent per comment id.
After the agent replies, the sweep checks the reply references the captured entry; if not, it logs and raises a needs-human note.
Unit tests for the capture (idempotency, source field) and the reply check.
Covered by #19086 (merged as 9312e1b): reviewer-stated rules are captured deterministically into the hive's review-rules knowledge channel with the source comment as provenance, idempotent per comment id, and a rule whose home is another project's repo gets exactly one needs-human note carrying the proposed text (tests: TestReviewFeedbackSweep_RuleCaptureIsIdempotent, TestReviewFeedbackSweep_ForeignRepoRuleGetsOneProposalNote). The sweep itself posts the "Recorded as rule R-n" reply, so a separate check that the agent's reply mentions the entry is no longer needed.
Activity
hivecommons-hive commentedon Nov 18, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).Claim history
Danathar(contributor on hive hosted-available-oke-11-placeholder-r05x)Danathar(contributor; lease revoked)scanner(agent on hive hosted-available-oke-11-placeholder-r05x)scanner(agent; holding agent relaunched)hivecommons-hive commentedon Nov 18, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: the
blockedlabel was applied by the hive without a blocked-on marker, so nothing could lift it. This issue is actionable again.clubanderson commentedon Nov 18, 2026
Covered by #19086 (merged as 9312e1b): reviewer-stated rules are captured deterministically into the hive's review-rules knowledge channel with the source comment as provenance, idempotent per comment id, and a rule whose home is another project's repo gets exactly one needs-human note carrying the proposed text (tests: TestReviewFeedbackSweep_RuleCaptureIsIdempotent, TestReviewFeedbackSweep_ForeignRepoRuleGetsOneProposalNote). The sweep itself posts the "Recorded as rule R-n" reply, so a separate check that the agent's reply mentions the entry is no longer needed.