Skip to content

🐛 Contributor gets a nudge, then the hive adopts the same PR minutes later (ladder rung 5) #18872

Closed

Description

@clubanderson

Child of #18450 (spam reduction), found by murtazox04 in its comment on #18450.

Problem

A contributor gets a "nudge" ("this PR is back in your court") and 16 to 39 minutes later the hive adopts the same PR. Two notifications, and the first asked for work the author no longer gets to do. Observed pairs:

PR nudge (reason) adopted (reason) gap
#18561 contributor-lane contributor-offline, supersede 16 min
#18628 fork-not-editable contributor-offline, supersede 33 min
#18514 check-failing contributor-offline, in-place 39 min
#18510 conflicting operator-forced 35 min

Cause (per the analysis on #18450, to be verified in code): pkg/delegatedecision/ladder.go, rung 5. When the grace has not elapsed but Conflicting || CIRed() || DCOMissing holds, the ladder decides "supersede now, do not wait for the grace deadline". Those are the same conditions that make the nudge go out, so a nudge for a red, conflicting or DCO-missing head is followed almost immediately by an adoption unless the author answers within minutes.

Wanted

Pick one outcome per head before anyone is notified:

  • If the ladder would supersede/adopt this head anyway, do not send the nudge; post only the adoption note.
  • If the hive means to give the author a real chance, the immediate-supersede branch must wait for the grace (or a minimum age since the nudge) and not fire on the same condition.

Choose the first unless the code shows the second is the documented intent; say which in the PR. Either way the author receives one notification, not two contradicting ones.

Acceptance

  • A head that the ladder would supersede immediately gets no nudge.
  • A head given a real chance is not superseded before the grace/minimum age after the nudge.
  • Tests assert both invariants against the four patterns above; docs updated; changelog fragment.
  • Expected effect: fewer contributor-lifecycle comments (the 7 adopted comments in the sample carry no nudge before them).

Activity

  1. self-assigned this
    on Nov 18, 2026
  2. clubanderson commented on Nov 18, 2026

    @clubanderson
    MemberAuthor

    Claimed; fix in progress.

  3. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    Contributor

    A hive agent asked to open a pull request that would close this issue, but it is already claimed by clubanderson. No PR was opened; the owner decides whether to proceed.

  4. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    Contributor

    A fix is pushed on branch scanner/fix-18872 (commit efcc3fe): it withholds the nudge for heads the ladder would supersede immediately, and holds 'Let hive decide' to a grace after a nudge. I did not open a PR because the issue is claimed by @clubanderson. Say if you want it opened, or take what's useful from the branch.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326

  5. clubanderson commented on Nov 18, 2026

    @clubanderson
    MemberAuthor

    Delivered by #18874 (merged to v5). Correction to the analysis in this issue: rung 5 of the ladder only runs when an operator presses 'Let hive decide'. The automatic nudge-then-adopt pairs come from nudgeContributor (automerge_contributor_nudge.go) and AutoAdoption (automerge_adoption_clock.go), which both key on the author being unreachable. The fix withholds the GitHub nudge comment when the hive will adopt anyway, so the author gets the single adoption note; online authors keep the nudge and the full grace. The v6 top-up carries it.

  6. added a commit that references this issue on Nov 18, 2026
    9d2b999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions