Skip to content

Activity monitor offers Approve / Request changes / Let hive decide on a row with no decision pending #18769

Closed

Description

@clubanderson

What happens

A tracker row can show the human-gate pill Needs human · review with Approve, Request changes… and Let hive decide while nothing is waiting on a person. Clicking a verb answers:

Let hive decide: nothing to act on — hivecommons/hive#18667 is not waiting on that decision

Seen on #18667: a person had already approved the head (Approve review plus /approve), so the PR left 085 and sits at its real stage waiting on required checks. Two of them (PR Type, PR Issue) are stuck in progress (#18764). The row still read "Needs human · review".

Why

The pill and the action precondition read two different sources:

  • the pill (stageTrackerHumanGateReasons) lights review whenever the cached reviewer verdict for the head is requires_human (review_activity.state == human_decision), whatever the PR's live stage;
  • the action (runRowAction -> stageTrackerDecisionTarget / stageTrackerPRParked) acts only on a PR the hive has actually parked on a person (085 / needs-decision / ready for human merge).

Once a person answers, the verdict for that head never changes, so the pill stays while the action refuses. The same split exists for the decision reason on rows flagged only by needs_human (triage needed, author-owned PRs) and for "Let hive decide" on hold / sentinel pills of rows that are not parked.

Expected

  • The pill and the verbs come from the same predicate the action uses; no verb is offered that would answer "nothing to act on".
  • When no decision is pending, the row names what it is actually waiting on: CI running (n/m), required checks stuck or missing (named), review re-run on a new head, merge queue, author's turn, conflict. A required check in progress far longer than a normal run reads "stuck", not "running".
  • A click from a stale view says what the item is waiting on and refreshes the row.

Activity

  1. self-assigned this
    on Nov 17, 2026
  2. clubanderson commented on Nov 17, 2026

    @clubanderson
    MemberAuthor

    Claimed: working on this now on branch fix/tracker-gate-truth; a PR will follow. Please do not dispatch a second fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions