Skip to content

🐛 merge path: hive's squash of #18079 landed f33758f5a on v5 without a Signed-off-by, and the post-merge DCO check skips bot authors so nobody saw it #18203

Closed

Description

@clubanderson

What happened

PR #18079 ([scanner] de-flake two tests) had a signed branch commit (c15eb728d, Signed-off-by present, author hivecommons-hive[bot]). The hive squash-merged it and the landing commit f33758f5a on v5 has this message body:

Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

No Signed-off-by trailer. The squash message template replaced the trailer with Co-authored-by lines.

Why it was not caught

  • .github/workflows/dco-post-merge.yml runs with DCO_SKIP_BOT_AUTHORS: 'true', so a bot-authored unsigned commit on the protected branch never turns the scheduled check red.
  • dco-squash-attribution.yml guards human-authored PRs signing off as a bot; it does not guard a bot PR whose squash drops the trailer.

Impact

Every PR whose commit range includes f33758f5a now fails the Prow dco status for real (not the App 1861 UNKNOWN case). First hit: the v5 to v6 top-up #18193, 286 commits, one unsigned. The commit is on the default branch and cannot be amended. Any other branch that merges v5 forward will hit the same wall once.

Fix

  1. Hive merge path: when squashing, carry the branch commits' Signed-off-by trailers into the squash message (or add the merging identity's own sign-off), and refuse to squash if the result has none. Cover with a test.
  2. dco-post-merge.yml: stop skipping bot authors for the missing-trailer check, or at least report bot-authored unsigned commits as a warning with an issue, so the next one is visible within a day instead of at the next forward merge.
  3. Disposition for f33758f5a itself is a maintainer call on 🌱 chore: top up v6 from v5 (2026-11-14) #18193 (the sign-off intent is on record in the source branch commit).

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 14, 2026
  2. hivecommons-hive commented on Nov 14, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-14 13:48 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-14 14:04 UTC — released by scanner (agent; holding agent relaunched)
  3. github-actions commented on Nov 14, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @kubestellar-prow[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions