Skip to content

Sentinel alerts and hold labels should be pills on the PR's real stage, not a forced needs-decision stage #17327

Closed
1 of 1 issue completed

Description

@clubanderson

Problem

A sentinel alert or a hold-class label on a PR today forces the stage to 085-needs-decision, whatever the PR's real progress. The stage engine treats sentinel / contributor-lane:sentinel-blocked / held / label:hold as needs-human reasons (stageNeedsHumanReasons in src/pkg/stageengine/derive_pr_classify.go), and stagelabels.RouteHuman adds "a sentinel alert is open on this PR" / "the hold label is set" to the decide list, which routes to 085 ahead of every progress rule.

The effect on the Activity monitor: a green, reviewed PR whose only outstanding matter is a sentinel confirmation sits in Review / "Needs human" next to PRs with real reviewer questions and changes-requested reviews. The cheapest decisions on the board (confirm intent on a sensitive-path edit; lift a hold) are hidden among the expensive ones, and the column no longer says where the PR actually is.

Owner decision (@clubanderson, 2026-11-08)

Sentinel alerts and hold labels are gates, not stages.

  • The PR's stage column reflects real progress: CI running / red → CI; reviewer question / changes requested → Review; checks green + verdict approve (or no verdict owed) → 090-ready-for-human-merge (Merge queue).
  • The sentinel / hold stays a hard merge stop and is shown as a pill on whatever stage the PR is at.
  • In the Merge queue column a sentinel- or hold-parked PR reads as a distinct held state — "Held · sentinel · confirm intent" / "Held · hold" — never as "Queued for merge".
  • needs-human label semantics are left as they are unless they fall out naturally; the decision covers sentinel and hold.

Acceptance criteria

  • Stage engine: sentinel and hold no longer override the derived stage; the stage comes from the head's progress (CI, verdict, human change request). The route reasons ("a sentinel alert is open on this PR", "held by label hold") are kept so the decision popover still explains the stop.
  • Hard stop preserved: no merge path (auto-merge lanes, approval desk, delegated decision, dashboard merge actions) merges a sentinel- or hold-parked PR because its stage is now 090; a test proves a 090 PR with Park.Sentinel=true is refused.
  • Dashboard: the Merge queue cell for a parked PR renders "Held · sentinel · confirm intent" / "Held · hold" with the amber pill styling and the route reason in the tooltip; the one-click actions (Approve / Let hive decide / Release hold) keep working from that cell; the 390 phone tier does not regress.
  • Stage goldens (src/pkg/stageengine/testdata/stage_goldens/) updated to the rule.
  • Docs state the rule: sentinel and hold are gates shown as pills; the column is the PR's real progress; a parked PR never merges unattended.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 9, 2026
  2. hivecommons-hive commented on Nov 9, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-09 01:44 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-09 01:57 UTC — released by Karibhou (contributor; lease revoked)
  3. github-actions commented on Nov 9, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

  4. added 2 commits that reference this issue on Nov 9, 2026
    79bbc6b
    16cfb66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dashboardDashboard UI and API issuesenhancementNew feature or requesthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions