You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Memory store path still resolved through symlinked ancestor directories #17256
Blocked on PR #17252.src/pkg/knowledge/climemory/memstore.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #17252.
PR: #17252 (#17252)
Perspective: security
Severity: medium (P2)
Finding: Memory store path still resolved through symlinked ancestor directories
Evidence: src/pkg/knowledge/climemory/memstore.go:33
openMemoryStore Lstat's the store path and compares it with os.SameFile against the opened os.Root, but both resolve through any symlink in an ancestor component. Sources are built in src/crux/agent/cli_memory.go:183 via filepath.Glob(home/.claude/projects//memory), which follows a symlinked , projects or .claude directory. An agent that points ~/.claude/projects/ at another agent's projects/ (or any hive-accessible tree containing memory/.md) passes memoryFiles (drain.go:368), passes the SameFile check (memstore.go:76), and gets the hive to drain that store under its own name and, with truncate:true, empty it once its facts are in the vault. Pre-existing and not the TOCTOU #17251 scoped; remediation: filepath.EvalSymlinks the source path and require it to stay under the agent's resolved home before opening the root.
Unblocked: #17252 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 8, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #17252 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 8, 2026
Unblocked: #17252 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 8, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)🐛 fix(knowledge/climemory): never follow a symlinked ancestor when op…