Skip to content

[scanner] ✨ retro: persist knowledge-advisor decisions and wire the production AdvisorDecisionReader (advisor phase 2, slice 4b) #17211

Closed

Description

@hivecommons-hive

Part of #17054 and follow-up to #17156 / PR #17207.

Why

#17207 adds AdvisorArm / AdvisorDecisions / AdvisorDelivered / AdvisorHeldOut to RetroRecord and the per-arm summary, consumed through an AdvisorDecisionReader interface keyed by the record's IssueRef. Nothing in production implements that reader yet: the ranking decorator (src/cmd/hive/knowledge_adviser_llm.go, #17202) records its decision only as the knowledge advisor: decision log line, prompt history records deliveries only (so holdout decisions never appear there), and kick IDs are agent#seq with no issue ref. Until a store exists, every bead reads AdvisorArm: none and the holdout comparison the RFC approved cannot be published on #17054, which in turn gates #17157 (owner condition 6).

Scope

  • Persist one compact decision record per decorator decision (agent, kick id, the kick's primed issue/PR refs from the scheduler KickSummary, arm: shadow|deliver|holdout, outcome, slug — no reason text, no pane text) in a small store the retro lane can read without parsing logs; follow the existing retro/prompt-history persistence patterns and retention.
  • Implement AdvisorDecisionReader over that store and wire it into the retro lane where RetroRecords are reconstructed, so ApplyAdvisorDecisions runs in production.
  • Tests: decorator writes a record per decision in rank/shadow/holdout; the retro lane reconstructs holdout / mixed / none from the store end to end; the stored record never contains reason or pane text.
  • Changelog fragment and a sentence in src/docs/retro-lane.md / src/docs/agent-knowledge-and-memory.md naming the store.

Decision taken by hive: simplest additive option — a dedicated decision store written by the decorator, not a change to prompt-history semantics (which intentionally records deliveries only).

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 8, 2026
  2. hivecommons-hive commented on Nov 8, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-08 08:10 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-08 08:46 UTC — released by scanner (agent; holding agent relaunched)
  3. added a commit that references this issue on Nov 8, 2026
    139a5a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agentarea/schedulerIssues or PRs related to edge workspaceenhancementNew feature or requesthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions