Skip to content

[reviewer] Review backlog (docs-currency): fleet-report.md skip list does not mention the new dampener exclusion #17111

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #17109.

PR: #17109 (#17109)
Perspective: docs-currency
Severity: info (P3)
Finding: fleet-report.md skip list does not mention the new dampener exclusion
Evidence: src/docs/fleet-report.md:165

| `unclassified_error_repeated` | **generic catch-all**: the same WARN/ERROR log line (numbers, hashes, paths and quoted strings collapsed) repeated ≥5 times in 10 min. Fed by a `slog.Handler` tee (`pkg/fleetreport/slogfeed`) on the hive's root logger, so a repeating defect is noticed even with no hook site. Skips benign lines (read/keepalive i/o timeouts, WARNs whose `error` is a GitHub rate-limit refusal or a 502/503/504 gateway failure — the caller retries next tick, context cancellation, the permissions watcher's `fixed …` self-healing lines) and any message that already matches another class's keywords. Clears automatically after 20 quiet minutes (2× the window), so a "cleared" comment follows once the symptom stops | low |

src/docs/fleet-report.md:165-183 enumerates several slogfeed exclusions for unclassified_error_repeated (rate-limit, 502-504, failClosedStatus500, 'review pending expired') but not the new stageDampenerSuppression skip added in src/pkg/fleetreport/slogfeed/slogfeed.go:235-237. The list is already partial (sentinelPacingSkip, reviewCommentCapped, automergeMergeGuardSkip, reviewRetryServerError are also absent), so this follows precedent and is advisory only; the changelog fragment changelog.d/fixed-17103.md documents the operator-visible change.

Fingerprint: aa14b9b8dda303144d1ef1936806f3d91ff4a9d3a27ff299e8a506a23867a2e6

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  2. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-07 21:54 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-07 22:06 UTC — released by scanner (agent; holding agent relaunched)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions