Skip to content

🌱 upsert signoff-attribution and unauthorized comments instead of reposting #17066

Closed

Description

@clubanderson

Problem

hive:signoff-attribution and hive:unauthorized comments are keyed on the head SHA, so every push to a long-lived PR gets a fresh copy of the same note. The 2026-11-07 spam audit found them among the largest remaining "unmarked/repeat" bot comment sources (30–46/day since 11-04).

Evidence on #16524 (🌱 chore: v5 → v6 top-up, 2026-11-04, UTC):

time marker head
03:01 hive:signoff-attribution eb40422
03:04 hive:signoff-attribution d61d907
05:45 hive:unauthorized step=rerun-shared-ci d61d907
12:04:59 hive:signoff-attribution ×2 (same second, same head) 2940830
12:12 hive:signoff-attribution 7879a51
12:16 hive:unauthorized step=rerun-shared-ci 7879a51
13:39 hive:signoff-attribution ad59ff3
13:45 hive:unauthorized step=rerun-shared-ci ad59ff3
18:17 hive:signoff-attribution 8f8d67b
18:25 hive:unauthorized step=rerun-shared-ci 8f8d67b
18:31 hive:signoff-attribution dc8ccef
18:39 hive:unauthorized step=rerun-shared-ci dc8ccef

8 × signoff-attribution + 5 × unauthorized, every one of them the same ask to the same person, each one an email.

Fix

Follow the shape #16434 (spam reducer #2) gave the claim ledger, stage-needs-decision and the sentinel: one comment per PR carrying a stable marker, found and edited in place when its content changes.

  1. hive:signoff-attribution → one comment per PR (<!-- hive:signoff-attribution -->); a new head rewrites it and appends a short updated <date>: head …, N commits line, history capped at 5 lines.
  2. hive:unauthorized → one comment per PR per blocked step (<!-- hive:unauthorized step=… -->); a further attempt on a new head edits the existing comment with an attempt count and the heads it covers instead of posting again. The existing per-head legacy comment is adopted and upgraded in place where one exists.
  3. Audit other automerge marker emitters that post per head without upsert; convert the ones with repeat risk, leave one-shot ones.

Code: src/pkg/github/automerge/automerge_unauthorized.go, nudgeSignoffAttribution (currently in automerge_contributor_nudge.go), workflowFenceReleased's head-marker read.

Verification by unit tests only — no live comments are edited or deleted on #16524.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  2. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-07 19:35 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-07 19:35 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    has-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions