Skip to content

[reviewer] Review backlog (correctness): bobPreflightUnlocked still probes /data/home/.bob writability though bob state now lands in the per-agent ~/.bob #17062

Closed

Description

@hivecommons-hive

Blocked on PR #17039. This finding came from reviewing PR #17039 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #17039.

PR: #17039 (#17039)
Perspective: correctness
Severity: low (P3)
Finding: bobPreflightUnlocked still probes /data/home/.bob writability though bob state now lands in the per-agent ~/.bob
Evidence: src/crux/agent/manager.go:1661

_ = m.verifyBobStateDirsWritable(agent.Name, bobSharedHome, m.workDir+"/"+agent.Name, agent.UID)

verifyBobStateDirsWritable(agent.Name, bobSharedHome, ...) (manager.go:1659-1661) checks /data/home/.bob, which after this PR holds only the bridged settings; bob's installation_id and tmp/ chat recordings are written under /data/home/agents//.bob. The diagnostic no longer describes the directory bob writes to and can mis-report; follow-up to point it at the per-agent home.

Fingerprint: f1bf2cbc3b0967c10b448a491de8d4f64b9ffcf31f7354eb10ff1f914c5fde1a

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 7, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 7, 2026
  4. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #17039 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  6. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #17039 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-07 20:19 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-07 22:06 UTC — released by scanner (agent; holding agent relaunched)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions