Skip to content

[reviewer] Review backlog (security): Shared agent-writable ~/.claude/settings.json remains a cross-agent hook/apiKeyHelper execution channel #17059

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #17039.

PR: #17039 (#17039)
Perspective: security
Severity: medium (P2)
Finding: Shared agent-writable ~/.claude/settings.json remains a cross-agent hook/apiKeyHelper execution channel
Evidence: src/deploy/entrypoint.sh:1738

chmod g+rwx /data/home/.claude 2>/dev/null || true

/data/home/.claude is chmod g+rwx (entrypoint.sh:1738) and ~/.claude/settings.json stays bridged to it for every agent (interactive_home.go:127). Claude Code user settings carry hooks and apiKeyHelper, so any agent uid or prompt-injected tool call can rename-replace the shared file and execute a command inside every other agent's next Claude session. Pre-existing and explicitly requested by #17031 so not blocking, but it undercuts the isolation this PR adds. Follow-up: hive-owned seed-and-verify of settings.json, or remove group write on the dir and route writes through the manager.

Fingerprint: a0f47142df9ec8acaef7dce50f6f3f3f56a2d5c5e1f86e42824ab7264b5e1635

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  2. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-07 20:20 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-07 22:06 UTC — released by scanner (agent; holding agent relaunched)
  3. github-actions commented on Nov 7, 2026

    @github-actions
    Contributor

    @hivecommons-hive[bot] this issue was closed by @clubanderson as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/claimed-by-scanner

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions