Skip to content

[reviewer] Review backlog (correctness): move-hub-registered-cutover.md cites env-vars.md:306-321 for derived keys, but that section is at 464-475 #17038

Closed

Description

@hivecommons-hive

Blocked on PR #17035. This finding came from reviewing PR #17035 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #17035.

PR: #17035 (#17035)
Perspective: correctness
Severity: low (P3)
Finding: move-hub-registered-cutover.md cites env-vars.md:306-321 for derived keys, but that section is at 464-475
Evidence: src/docs/move-hub-registered-cutover.md:41

see `src/docs/env-vars.md:306-321` and, for the heartbeat bearer

The PR shifts the citation from env-vars.md:305-320 to 306-321 to account for the inserted CRUX_RUNS_CONFIG row. The shift is mechanically correct, but the cited range (before and after) covers the OPENAI_/HIVE__BACKOFF rows, not the HMAC(HIVE_HUB_SECRET, domain, HIVE_ID) derived-key rows the sentence describes; those live at src/docs/env-vars.md:464-475 at head c687ceb (HIVE_HEARTBEAT_KEY, HIVE_SESSION_KEY, HIVE_INVITE_KEY, HIVE_TERMINAL_KEY). Pre-existing stale anchor that check-docs-citations.py did not catch; a follow-up should repoint it to the derived-key table.

Fingerprint: 359656acc5e1f595fc9b478a196e3eda2b5b9740da36a9beb152a1df42c5d937

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 7, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 7, 2026
  4. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #17035 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  6. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #17035 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    🌱 Good first issue — bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-available-oke-11-placeholder-r05x picked this issue as a good place to start because:

    • scoped to two packages (docs, hivecommons/hive)
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2317038 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #17038 — that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #17038 in github.com/hivecommons/hive (https://github.com/hivecommons/hive/issues/17038). First open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2317038 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #17038' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/hivecommons/hive/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.

  8. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Nov 7, 2026
  9. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

    Claim history
    • 2026-11-07 21:45 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-07 23:27 UTC — released by thatguywob (contributor; lease revoked)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agentgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions