You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): runs: workspace_path root check is lexical; a symlink under a workspace root escapes workspace_roots #17029
Blocked on PR #17025.src/crux/runs/service.go does not exist on v6; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #17025.
PR: #17025 (#17025)
Perspective: security
Severity: low (P3)
Finding: runs: workspace_path root check is lexical; a symlink under a workspace root escapes workspace_roots
Evidence: src/crux/runs/service.go:318
validateWorkspace (service.go:292-299) cleans the path and pathUnder (service.go:318-324) does a string-prefix check against Config.WorkspaceRoots, then os.Stat follows symlinks. No filepath.EvalSymlinks is applied, so /x where x is a symlink to / passes and sandbox.go:141 mounts it rw with --userns=keep-id (sandbox.go:140). A previous untrusted run can plant that symlink in its rw workspace, so a later authenticated request naming the symlinked path mounts arbitrary host paths as the crux serve user. Caller is the authenticated operator so exploitability is low; fix by resolving with filepath.EvalSymlinks before pathUnder. Pre-existing in v5 commit 03094ce; not introduced by this forward-merge.
Unblocked: #17265 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 8, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #17265 (superseding #17025) is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 8, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)hivecommons-hive commentedon Nov 8, 2026
Unblocked: #17265 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🐛 fix(crux/runs): resolve symlinks before the workspace_roots check (#…