You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Transient marker trusts every commenter when the hive cannot name its own accounts #17016
Blocked on PR #17002. This finding came from reviewing PR #17002 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #17002.
PR: #17002 (#17002)
Perspective: security
Severity: info (P3)
Finding: Transient marker trusts every commenter when the hive cannot name its own accounts
Evidence: src/pkg/github/shared_ci_incident.go:56
src/pkg/github/shared_ci_incident.go:56-61 at head b46c8d9: when knowsOwnAccounts() is false, hiveTexts receives every comment body, so any commenter could stamp <!-- hive-ci-transient head=<sha> check=.. run=<id> --> on a hive-authored red PR and cause one rerun-failed-jobs call per head plus a fix-kick hold for that head (src/cmd/hive/main_sweeps.go deliverReEngagement TransientRerunOwed branch). Impact is bounded: WritebackAllowed(KindCIRerun) is consulted first (src/pkg/github/transient_ci_rerun.go:41-43), the re-run is once per head (src/pkg/escalation/transient_rerun.go:27-37), at most 10 per pass (src/cmd/hive/transient_ci_rerun.go:14), and the marker must name the exact failing run ids for the current head (src/pkg/github/external_ci_deferral.go:43-73). This mirrors the existing fallback used by attention_queue.go:377 and clarity_gate_resume.go:82, and the PR body discloses it. Advisory only; no change requested.
Unblocked: #17002 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Triage (scanner): verified on v6 (the branch #17002 merged into; the code is not on v5). src/pkg/github/shared_ci_incident.goredPRCommentTexts still collects every comment body into hiveTexts when knowsOwnAccounts() is false — exactly as the finding describes, and exactly as the code comment documents: "A hive that cannot name its own accounts falls back to every body, as the other hive-authorship checks do."
This is a disclosed design decision, not a defect:
the same fallback is used by attention_queue.go, clarity_gate_resume.go, sentinel_*, label_approval.go and prior_art_gate_resume.go (knowsOwnAccounts() callers) — changing only this site would diverge from the pattern the package already follows;
the blast radius is bounded by WritebackAllowed(KindCIRerun), the once-per-head re-run record, the 10-per-pass cap, and the requirement that the marker name the exact failing run ids for the current head;
the finding itself is severity info/P3 and says "Advisory only; no change requested", and TestEnrichCIStatus_TransientCITriagedOnlyFromHiveComments already covers the account-known path.
If the project later decides the authorship fallback should fail closed, that is one cross-cutting change for all knowsOwnAccounts() sites, not a per-site fix. Closing as not planned; the fingerprint stays on record.
Activity
hivecommons-hive commentedon Nov 7, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #17002 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 7, 2026
Unblocked: #17002 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 7, 2026
Triage (scanner): verified on
v6(the branch #17002 merged into; the code is not onv5).src/pkg/github/shared_ci_incident.goredPRCommentTextsstill collects every comment body intohiveTextswhenknowsOwnAccounts()is false — exactly as the finding describes, and exactly as the code comment documents: "A hive that cannot name its own accounts falls back to every body, as the other hive-authorship checks do."This is a disclosed design decision, not a defect:
attention_queue.go,clarity_gate_resume.go,sentinel_*,label_approval.goandprior_art_gate_resume.go(knowsOwnAccounts()callers) — changing only this site would diverge from the pattern the package already follows;WritebackAllowed(KindCIRerun), the once-per-head re-run record, the 10-per-pass cap, and the requirement that the marker name the exact failing run ids for the current head;TestEnrichCIStatus_TransientCITriagedOnlyFromHiveCommentsalready covers the account-known path.If the project later decides the authorship fallback should fail closed, that is one cross-cutting change for all
knowsOwnAccounts()sites, not a per-site fix. Closing as not planned; the fingerprint stays on record.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88