Skip to content

[reviewer] Review backlog (intent-alignment): What-hive-saw facts omit the options and recommendation the new rules read #16940

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16935.

PR: #16935 (#16935)
Perspective: intent-alignment
Severity: low (P3)
Finding: What-hive-saw facts omit the options and recommendation the new rules read
Evidence: src/pkg/delegatedecision/facts.go:177

if q := strings.TrimSpace(in.Question); q != "" {

Upstream #16936 (merged into this branch in the delta) added Input.Facts() with the contract 'Only facts the rules use are listed' (facts.go:28-31), but Facts() reads Question (facts.go:177-179) and nothing of Input.Options / Input.RecommendedOption (policy.go:206-207), which competingOptionsDecision depends on (competing_options.go:45-66). For an issue like utah#920 the plan says 'Leave the choice to you ... 3 options' while the 'What hive saw' panel lists no options, so the owner cannot check the competing-options/recommended-option verdict against its inputs. Not required by #16934; fix is to add an 'Options offered' / 'Recommended option' fact pair after the Question fact (patch in the review comment).

Fingerprint: f2435d1674b9a8ac57da4ee451f638cd4b16d3803de5ad61b982e27f5d5fe71e

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  2. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-06 16:07 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
  3. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16941 (merged 42f773f). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions