You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Issue-author-controlled option text is quoted into an owner-attributed /hive decision (mitigated) #16937
Blocked on PR #16935.src/pkg/github/issue_decision_options.go does not exist on v6; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #16935.
PR: #16935 (#16935)
Perspective: security
Severity: info (P3)
Finding: Issue-author-controlled option text is quoted into an owner-attributed /hive decision (mitigated)
Evidence: src/pkg/github/issue_decision_options.go:19
IssueDecisionOptions reads options and the recommendation from the issue body regardless of author (only comments are gated by isHiveAccount, issue_unpark_menu.go:103 and issue_decision_options.go:35), so a non-hive reporter can author the option summary that the delegate records as '/hive decision go with option N:
' attributed to the owner via RecordOperatorIssueDecision (api_repo_item_decide_delegated.go:1094). This matches the pre-existing trust posture of the 'What to reply' notice (unparkMenuFromBody, issue_unpark_menu.go:62) and is mitigated: the summary passes unparkCleanOptionSummary (issue_unpark_command.go:1575-1586: HTML comments incl. unclosed ones stripped, @mentions defanged, one line, 160 runes), the dashboard escapes it (tracker-actions.js:1686-1688), and the owner sees the exact option named in the plan before executing. No action required for this PR; noted for any future path that executes a recommended option without an owner preview.
Unblocked: #16935 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Re-verified on v6 @ 42f773f after #16935 merged. The reviewer's own finding marked this mitigated / no action required, and re-verification confirms it. (Ignore the preceding "test" comment, posted in error.) Recommend closing as not planned.
Cleaner: unparkCleanOptionSummary (src/pkg/github/issue_unpark_command.go:1575) strips HTML comments incl. unclosed (unparkHTMLCommentPattern :1536), defangs @mentions (defangMentions, issue_blocked.go:1087), single line, 160-rune cap (:1531).
Applied at parse: src/pkg/github/issue_decision_options.go:98 (and issue_unpark_command.go:1567).
Recorded decision: api_repo_item_decide_delegated.go:1100 passes d.Text (built from cleaned Option.Name(), delegatedecision/competing_options.go:33-39) to RecordOperatorIssueDecision.
Dashboard escapes via esc() (static-src/js/tracker-actions.js:1045, :650).
Owner preview: delegatedPlanWording (dashboard/api_repo_item_decide_delegated_plan.go:393) shows the exact decision text before execution.
No path found that executes a recommended option without that preview.
Activity
hivecommons-hive commentedon Nov 6, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16935 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 6, 2026
Unblocked: #16935 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 6, 2026
test
🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Nov 6, 2026
Re-verified on v6 @ 42f773f after #16935 merged. The reviewer's own finding marked this mitigated / no action required, and re-verification confirms it. (Ignore the preceding "test" comment, posted in error.) Recommend closing as not planned.
🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Nov 6, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).Claim history
scanner(agent on hive hosted-available-oke-11-placeholder-r05x)scanner(agent; holding agent relaunched)hivecommons-hive commentedon Nov 6, 2026
Fixed by #16949 (merged c2ff975). Closing. Reply /reopen if the problem persists.