Skip to content

[reviewer] Review backlog (security): Issue-author-controlled option text is quoted into an owner-attributed /hive decision (mitigated) #16937

Closed

Description

@hivecommons-hive

Blocked on PR #16935. src/pkg/github/issue_decision_options.go does not exist on v6; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16935.

PR: #16935 (#16935)
Perspective: security
Severity: info (P3)
Finding: Issue-author-controlled option text is quoted into an owner-attributed /hive decision (mitigated)
Evidence: src/pkg/github/issue_decision_options.go:19

func (c *Client) IssueDecisionOptions(issueBody string, issueAuthor *gh.User, comments []*gh.IssueComment) (options []delegatedecision.Option, recommended string) {

IssueDecisionOptions reads options and the recommendation from the issue body regardless of author (only comments are gated by isHiveAccount, issue_unpark_menu.go:103 and issue_decision_options.go:35), so a non-hive reporter can author the option summary that the delegate records as '/hive decision go with option N:

' attributed to the owner via RecordOperatorIssueDecision (api_repo_item_decide_delegated.go:1094). This matches the pre-existing trust posture of the 'What to reply' notice (unparkMenuFromBody, issue_unpark_menu.go:62) and is mitigated: the summary passes unparkCleanOptionSummary (issue_unpark_command.go:1575-1586: HTML comments incl. unclosed ones stripped, @mentions defanged, one line, 160 runes), the dashboard escapes it (tracker-actions.js:1686-1688), and the owner sees the exact option named in the plan before executing. No action required for this PR; noted for any future path that executes a recommended option without an owner preview.

Fingerprint: 5e3a75596bcaccaba4c8ee3ed5cb36c8eba111533574cbc99c80555c97ebe7a7

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 6, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 6, 2026
  4. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16935 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16935 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  7. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    test


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  8. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Re-verified on v6 @ 42f773f after #16935 merged. The reviewer's own finding marked this mitigated / no action required, and re-verification confirms it. (Ignore the preceding "test" comment, posted in error.) Recommend closing as not planned.

    • Cleaner: unparkCleanOptionSummary (src/pkg/github/issue_unpark_command.go:1575) strips HTML comments incl. unclosed (unparkHTMLCommentPattern :1536), defangs @mentions (defangMentions, issue_blocked.go:1087), single line, 160-rune cap (:1531).
    • Applied at parse: src/pkg/github/issue_decision_options.go:98 (and issue_unpark_command.go:1567).
    • Recorded decision: api_repo_item_decide_delegated.go:1100 passes d.Text (built from cleaned Option.Name(), delegatedecision/competing_options.go:33-39) to RecordOperatorIssueDecision.
    • Dashboard escapes via esc() (static-src/js/tracker-actions.js:1045, :650).
    • Owner preview: delegatedPlanWording (dashboard/api_repo_item_decide_delegated_plan.go:393) shows the exact decision text before execution.
    • No path found that executes a recommended option without that preview.

    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  9. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-06 17:14 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-06 18:12 UTC — released by scanner (agent; holding agent relaunched)
  10. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16949 (merged c2ff975). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions