Skip to content

🐛 [v6] "Let hive decide" approves a bare "direction" on an issue that offers competing options #16934

Closed

Description

@Danathar

Target: v6.

Summary: On an issue that asks its owner to pick one of several options, "Let hive decide" offers "Approve the direction of #N and let the hive pick it up". That records no choice, so whichever agent claims the issue picks an option itself, possibly the largest. The delegate should either go with the option the issue recommends and name it, or leave the choice to a person.

What happened

projectbluefin/utah#920 is parked at stage/045-needs-decision. Its body lists three mutually exclusive ways to ship debugging tools under "Pick one:":

  1. carry them in the image (every variant grows),
  2. a ujust recipe,
  3. a -dx/debug flavor.

The 045 comment on it says "Maintainer Decision Required … three competing delivery mechanisms". The Let hive decide dialog (dashboard, 2026-11-06) still offered:

Approve the direction of #920 and let the hive pick it up.
WHY No owner rule singles this out.
THEN Hive records approval and removes the needs-decision hold; an agent claims #920 on the next cycle.

Why (hivecommons/hive v6 @ 8521076)

  • src/pkg/dashboard/api_repo_item_decide_delegated_plan.go:330-335 returns that sentence for any VerdictApprove on an issue.
  • The verdict comes from the fallback rule default-approve (src/pkg/delegatedecision/policy.go:603), whose recorded text is "go with the recommendation; where options remain, take the one that keeps work moving and is reversible". That hands the choice to the claiming agent.
  • delegatedecision.Input carries Body and Question, but no rule reads the options an issue lists. The "What to reply" notice already parses lettered options (unparkOptionLabels, src/pkg/github/issue_unpark_command.go:1499, extended for list items in 🐛 unpark: read list-item options on a 045 park; 045 asks name a recommendation #16159), but only A-F letters, and nothing passes them to the delegate. utah#920's options are numbered.
  • The LLM decider only replaces the reversible default (IsReversibleDefault, src/pkg/delegatedecision/llm.go:99), so an item that leaves default-approve also leaves the LLM's hands.

Expected

When the issue body or the newest hive park comment lists two or more alternatives, Let hive decide must never offer a bare "approve the direction". Either:

  • (a) the same text recommends one: go with it, name it in the plan sentence, and record it in the /hive decision text the claiming agent receives; or
  • (b) it recommends none: refuse ("this asks a person to choose between N options"), write nothing, and offer Give direction.

Acceptance criteria

  • Lettered options are read exactly as the "What to reply" notice reads them (same parser, same hive-comment precedence).
  • Numbered options (1./1)) count only when the line before item 1 reads as a choice ("Pick one:", "competing", "options", "either", …). A numbered list of steps is not options: utah#920's own "What it cost" section has one.
  • Numbered recommendations need an explicit reference ("option 2", "Recommendation: 2", "I recommend 3"). A stray number ("saves 3 hours") is not a recommendation.
  • Option summaries quoted into hive comments are sanitised like the notice's: HTML comments stripped, @mentions defanged, cut to one line.
  • The new rules have glossary entries (Go glossary, JS mirror, docs table).

Tests

  • Issue body with three numbered options under "Pick one:" at 045 → plan would: refused, rule competing-options, summary names the three options, nothing written, Give direction offered.
  • Same body plus "Recommendation: option 2" → plan names option 2; executing records /hive decision go with option 2: ….
  • utah#920's "What it cost" steps alone → no options.
  • Lettered options with "My recommendation is B" → option B.

Out of scope

  • Teaching the "What to reply" notice to offer /hive decision 1|2|3 for numbered options. The notice still reads letters only.
  • Changing which issues park at 045.

PR: (linked below)

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  2. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    Contributor

    Fixed by #16935 (merged a33dc36). Closing. Reply /reopen if the problem persists.

  3. github-actions commented on Nov 6, 2026

    @github-actions
    Contributor

    @Danathar this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions