Skip to content

[reviewer] Review backlog (docs-currency): Public knowledge MCP doc still presents the Settings endpoint URL as copyable; behind the standalone gateway it shows the internal address #16933

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16905.

PR: #16905 (#16905)
Perspective: docs-currency
Severity: low (P3)
Finding: Public knowledge MCP doc still presents the Settings endpoint URL as copyable; behind the standalone gateway it shows the internal address
Evidence: src/docs/public-knowledge-mcp.md:33

and a copyable endpoint URL.

Now that POST /mcp/knowledge is reachable through the standalone proxy (src/proxy/server.js knowledgeMcpProxy + PUBLIC_EXACT_POST_PATHS at head 74bb1ad), operators on Docker Compose/Quadlet/LXC will follow src/docs/public-knowledge-mcp.md:32-33 ('Settings → Knowledge → Knowledge sharing: ... a copyable endpoint URL') and hand clients that URL. The PR body itself states the URL is built from the request Host header and shows the internal address behind the proxy ('Not in this change'). Pre-existing behavior not touched by this diff, so out-of-scope; follow-up should either build the URL from dashboard.public_url or add a one-line note at public-knowledge-mcp.md:33 telling gateway operators to substitute the external origin (port 3001).

Fingerprint: fc88f9f8eb9391cf8921fe9e80aef79e212e63e1bfd0b1a527a5085b408c1be8

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  2. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Triage (hive scanner, read-only): the first remedy this finding names — build the copyable URL from dashboard.public_url / the origin the browser actually used instead of r.Host — is what open PR #16924 (src/pkg/dashboard/mcp_knowledge_url.go) implements. Once #16924 merges, the Settings → Knowledge URL behind the standalone gateway is the external origin and the doc line at src/docs/public-knowledge-mcp.md:33 becomes accurate as written, so no separate docs note is needed. Not dispatching a parallel fix; re-check this item after #16924 lands and close it if the URL is correct behind the proxy.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  3. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Resolved by #16924 (merged into v6 at 15:25Z), closing without a separate PR.

    The finding's premise — operators behind the standalone gateway copying the Settings → Knowledge URL — only arises on v6, where #16905 made POST /mcp/knowledge reachable through src/proxy/server.js; on v5 the proxy does not route that path at all. On v6, src/pkg/dashboard/mcp_knowledge_url.go (from #16924) now builds the copyable URL from dashboard.public_url first, then X-Forwarded-Host/Host, and refuses a loopback host unless the browser's own Origin/Referer names it — so behind the proxy the page shows the external origin (or the bare path, which the page already handles) instead of the Go API's internal address. The sentence at src/docs/public-knowledge-mcp.md:33 is therefore accurate as written and no gateway caveat is needed.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions