You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): repo_conventions serves uncapped full bodies while knowledge caps at 16 KiB #16925
Blocked on PR #16919. This finding came from reviewing PR #16919 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16919.
PR: #16919 (#16919)
Perspective: security
Severity: low (P3)
Finding: repo_conventions serves uncapped full bodies while knowledge caps at 16 KiB
Evidence: src/pkg/dashboard/task_mcp_phase3.go:72
knowledgeItems wraps the re-read body in capKnowledgeBody (task_mcp_phase3.go:104), but repoConventionItems passes fact.Body through uncapped after the same fullKnowledgeFact re-read (task_mcp_phase3.go:67,72). taskmcp.MaxTextBytes is only applied to inbound request bodies (crux/taskmcp/taskmcp.go:329), so there is no transport-level output clamp. A very large convention page can still be pushed whole into an agent's context. Pre-existing (repo_conventions already called FullFact before this PR); suggest applying capKnowledgeBody at task_mcp_phase3.go:72 as well.
Closed as completed: #16919 merged and repo_conventions is no longer in src/pkg/dashboard/task_mcp_phase3.go on v6, so this finding no longer applies. Reopen if it does.
Activity
hivecommons-hive commentedon Nov 6, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16919 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 6, 2026
Closed as completed: #16919 merged and
repo_conventionsis no longer insrc/pkg/dashboard/task_mcp_phase3.goon v6, so this finding no longer applies. Reopen if it does.