Skip to content

[reviewer] Review backlog (security): repo_conventions serves uncapped full bodies while knowledge caps at 16 KiB #16925

Closed

Description

@hivecommons-hive

Blocked on PR #16919. This finding came from reviewing PR #16919 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16919.

PR: #16919 (#16919)
Perspective: security
Severity: low (P3)
Finding: repo_conventions serves uncapped full bodies while knowledge caps at 16 KiB
Evidence: src/pkg/dashboard/task_mcp_phase3.go:72

Data: taskmcp.ServedText{Title: fact.Title, Body: fact.Body},

knowledgeItems wraps the re-read body in capKnowledgeBody (task_mcp_phase3.go:104), but repoConventionItems passes fact.Body through uncapped after the same fullKnowledgeFact re-read (task_mcp_phase3.go:67,72). taskmcp.MaxTextBytes is only applied to inbound request bodies (crux/taskmcp/taskmcp.go:329), so there is no transport-level output clamp. A very large convention page can still be pushed whole into an agent's context. Pre-existing (repo_conventions already called FullFact before this PR); suggest applying capKnowledgeBody at task_mcp_phase3.go:72 as well.

Fingerprint: bc7b3bd9bb5698f90c30560243d5fb322cc0fcd1260cc0a6f1b577bf25e1d3b3

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 6, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 6, 2026
  4. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16919 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Closed as completed: #16919 merged and repo_conventions is no longer in src/pkg/dashboard/task_mcp_phase3.go on v6, so this finding no longer applies. Reopen if it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions