Skip to content

[reviewer] Review backlog (correctness): securityFindingAcross reads raw verdicts while the gate reads scope-effective ones #16865

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16863.

PR: #16863 (#16863)
Perspective: correctness
Severity: low (P3)
Finding: securityFindingAcross reads raw verdicts while the gate reads scope-effective ones
Evidence: src/pkg/review/security_finding.go:137

if !r.DecisionRequested && r.Verdict != VerdictRequiresHuman {

The new branch at review.go:636 is entered on seenVerdicts built from ScopeEffectiveReports (review.go:1288 downgrades a report whose findings are all out-of-scope to approve), but securityFindingAcross (security_finding.go:137) and IsSecuritySensitiveFinding (security_finding.go:80) test r.Verdict on the raw report. A security report with raw requires_human and only out-of-scope findings can therefore still back the hold when another perspective supplies the effective requires_human. The pre-existing bare path at review.go:653 has the identical mismatch, so this PR does not introduce it; noted for a later alignment.

Fingerprint: 9207c9d5cbb743e76bcd546c30e9c167ca3fee1e8baf0075d15d1d840bdb1e00

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  2. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-06 02:35 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions