Skip to content

[reviewer] Review backlog (security): BaseRefreshChecker trusts email-derived GitHub login and a 300-file compare cap #16860

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16858.

PR: #16858 (#16858)
Perspective: security
Severity: low (P3)
Finding: BaseRefreshChecker trusts email-derived GitHub login and a 300-file compare cap
Evidence: src/pkg/github/pr_decision_base_refresh.go:223

func CommitByGitHubLogin(commit *gh.RepositoryCommit, login string) bool {

CommitByGitHubLogin (222-229) claims it reads server-resolved logins and never the forgeable email, but GitHub derives commit author.login from the author email, so a contributor can attribute a merge commit to the App bot via its noreply address. The merge-base check (150-160) and sameChangedFiles (187-215) prevent content smuggling, but compareAllFiles (162-185) relies on a compare whose files list GitHub caps at 300, so a >300-file PR is compared on a truncated list. Pre-existing in the checker (hive#15649), now also backing the workflow-path fence; backlog item: verify commit.verification or the update-branch effects ledger instead of attribution, and fail closed when the compare reports 300 files.

Fingerprint: cf6e846039475ac49dce20d94962ded5b160a4657dda1cc5d165f29cb6060981

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 6, 2026
  2. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-06 02:19 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions