Skip to content

[reviewer] Review backlog (security): Relay blocked-label release removes blocked without checking who applied it #16841

Closed

Description

@hivecommons-hive

Blocked on PR #16832. This finding came from reviewing PR #16832 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16832.

PR: #16832 (#16832)
Perspective: security
Severity: low (P3)
Finding: Relay blocked-label release removes blocked without checking who applied it
Evidence: src/pkg/dashboard/contribute_blocked_tooling.go:168

if err := client.RemoveLabel(ctx, repo, number, blockedWorkflowLabel); err != nil {

releaseToolingBlockedLabel calls client.RemoveLabel(ctx, repo, number, blockedWorkflowLabel) unconditionally (contribute_blocked_tooling.go:168-171) with no timeline/actor check, unlike askHumanBlockedMarkerless (issue_blocked.go:650-657) which gates on blockedLabelActor. This PR widens the trigger from tooling-failure reasons to any empty/footer-only reason, so a contributor agent that returns a blank blocked verdict on an issue a maintainer labelled blocked mid-task would strip the human's label. Pre-existing mechanism (the same effect was already reachable with a 'push rejected' reason) and the claim gate refuses already-blocked issues at assignment, so no new capability is granted; a follow-up could reuse blockedLabelActor here so only an App-bot-applied blocked is released.

Fingerprint: 61662d5f37fcd0164cad7af503f5774225539021d5961323dd21e66812f9e4ac

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16832 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16832 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  7. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-06 00:08 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-06 01:37 UTC — released by scanner (agent; holding agent relaunched)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions