Skip to content

🐛 [v6] Workflows blocker card says "grant the App workflows: write" when the App has it; never offers the workflows-lane hand-off #16804

Closed

Description

@Danathar

Target: v6.

Summary

When a lane parks a workflow-only change because its token tier leaves out workflows, the dashboard's blocker card says the App is missing the permission. Its first option is "Grant the App workflows: write". On a live hive (projectbluefin, build f0c02da) that is wrong:

  • the App already requests workflows: write, and
  • trusted- and merger-tier tokens mint with it (the "scoped token mint with workflows:write failed" warning has not appeared in the log since at least 11-05 11:47Z).

The real cause is that the parking lane (sec-check) is not at a tier that asks for it. The card never offers the fix #16692 added: hand the change to the lane that can push workflow files (hive/workflows-lane → WorkflowsCapableLane, here scanner at ISSUES_PRS_MERGE).

Example: projectbluefin/gutenprint-printer-app#163, parked by sec-check on 11-01, before #16692 merged.

  • The card offers "Grant the App workflows: write" and "Re-check permissions".
  • "Let hive decide" is disabled with "No decision grants the App the permission".
  • The operator is sent to an App settings page where nothing needs changing.
  • "Re-check permissions" would find the permission granted and release the item back to sec-check, which still cannot push it, so it would park again.

Where

All references are at af3059ad3 (origin/v6).

  • src/pkg/dashboard/item_blocker.go:115-142 (blockerDecisionOptions): for any capability blocker, offers App settings, re-check and patch. It never offers a hand-off to the workflows lane.
  • src/pkg/dashboard/item_blocker.go:168-171 (blockerQuestionTail): "Options: (a) grant the App workflows: write …".
  • src/pkg/dashboard/item_blocker.go:77 (decisionWhyBlockerCapability): disables "Let hive decide".
  • src/pkg/github/issue_workflows_handoff.go:72-80 (workflowsHandoff): the hand-off exists, but only runs when a lane posts a park (relay path). Issues parked before 🐛 fix(relay): hand a workflow-only park to the lane that can push it #16692 keep the owner-facing blocker.
  • src/pkg/config/workflows_lane.go:81 (WorkflowsLaneFor): already answers "which lane can push this for that agent in that repo".

Fix

For a workflows capability blocker on an issue:

  1. Offer the hand-off first. If WorkflowsLaneFor(<parking agent>, repo) names a lane, the first option should be "Hand to <lane> (its token can push workflow files)". It adds hive/workflows-lane, un-parks the issue and records the decision. Keep the App-settings option only when no lane can push workflows.
  2. Re-check before blaming the App. If the installation already grants workflows: write, say so ("the App has it; <agent>'s token tier does not ask for it"). Don't present granting it as the fix.
  3. Allow "Let hive decide" when a capable lane exists, and have it take the hand-off.

Acceptance criteria

  • With a capable lane serving the repo, the card for a sec-check (or other non-trusted-tier) workflows park offers the hand-off as option (a), and choosing it routes the issue to that lane on the next schedule.
  • When the installation grants workflows, the card does not tell the operator to grant it.
  • With no capable lane and no grant, today's options are unchanged.

Test plan

  • Table tests on blockerDecisionOptions and blockerQuestionTail for three cases:
    • capable lane present;
    • none present, and the App grants workflows;
    • none present, and the App does not grant it.
  • A handler test that the hand-off action adds hive/workflows-lane, clears the park, and that routeWorkflowsLane then picks the capable lane.

Out of scope

  • Changing which tiers request workflows (modePushesWorkflows).
  • Non-workflows capability blockers.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  2. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-05 20:27 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 20:35 UTC — released by Karibhou (contributor; lease revoked)
  3. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    Contributor

    Fixed by #16807 (merged f5c3ac1). Closing. Reply /reopen if the problem persists.

  4. github-actions commented on Nov 6, 2026

    @github-actions
    Contributor

    @Danathar this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions