Skip to content

Train-queued approved PRs caption says 'waiting for a verdict' while Review shows 5/5 approved #16756

Closed

Description

@clubanderson

What happens

Activity Monitor (spoke /api/stage-tracker): PRs parked in the base preparation train behind the front show a caption that contradicts their Review chevron.

Live sample (verbatim):

Row header: Preparation train · 6 confirmed PRs · recorded front: #16718.

Why

derive_pr_classify.go files every base-refresh: reason under 050 regardless of the head's verdict, and stageTrackerCaption composes the 050 lead ("Review swarm requested; waiting for a verdict on the current head") from the stage alone, before the review track for the head is attached. The stage actor's next-move line ("review swarm — waiting for a verdict …") is built the same way.

Expected

An approved train member's caption says what it actually waits on — its turn behind the front, e.g. Approved 5/5 · queued for base refresh behind PR #16718. A still-reviewing member and the 060 "waiting for merge admission" wording are unchanged.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  2. added a commit that references this issue on Nov 5, 2026
    f2ca9bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions