You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): App bot login trust assumes the GitHub App is installed only by this hive #16743
Blocked on PR #16736.src/pkg/github/workflow_auto_approval.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #16736.
PR: #16736 (#16736)
Perspective: security
Severity: low (P3)
Finding: App bot login trust assumes the GitHub App is installed only by this hive
Evidence: src/pkg/github/workflow_auto_approval.go:271
workflowApprovalTrusted trusts any gated run whose triggering_actor equals AppBotLogin(). The new comment (lines 186-193) argues the App cannot push to a fork, which holds for an installation token scoped to the base repo. If the GitHub App is public and a contributor installs it on their fork, pushes from that installation carry the same [bot] login, so a fork head of contributor-controlled code would be approved as 'the App'. Remediation: document that the App must be private to the owner, or require run.HeadRepository == base repo in the actor (not author) branch. Not required by #16603; advisory.
Same file as #16738: both cite src/pkg/github/workflow_auto_approval.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
Unblocked: #16736 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 5, 2026
Same file as #16738: both cite
src/pkg/github/workflow_auto_approval.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16736 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).Claim history
scanner(agent on hive hosted-available-oke-11-placeholder-r05x)scanner(agent; holding agent relaunched)hivecommons-hive commentedon Nov 5, 2026
Unblocked: #16736 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 5, 2026
Fixed by #16783 (merged e5fd0f1). Closing. Reply /reopen if the problem persists.