Skip to content

[reviewer] Review backlog (security): App bot login trust assumes the GitHub App is installed only by this hive #16743

Closed

Description

@hivecommons-hive

Blocked on PR #16736. src/pkg/github/workflow_auto_approval.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16736.

PR: #16736 (#16736)
Perspective: security
Severity: low (P3)
Finding: App bot login trust assumes the GitHub App is installed only by this hive
Evidence: src/pkg/github/workflow_auto_approval.go:271

app := c.AppBotLogin()

workflowApprovalTrusted trusts any gated run whose triggering_actor equals AppBotLogin(). The new comment (lines 186-193) argues the App cannot push to a fork, which holds for an installation token scoped to the base repo. If the GitHub App is public and a contributor installs it on their fork, pushes from that installation carry the same [bot] login, so a fork head of contributor-controlled code would be approved as 'the App'. Remediation: document that the App must be private to the owner, or require run.HeadRepository == base repo in the actor (not author) branch. Not required by #16603; advisory.

Fingerprint: ebc5f4b15ffe2b45556429fc633ea09cbf5833ac6084a4f1233fc697c631d3b2

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #16738: both cite src/pkg/github/workflow_auto_approval.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16736 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-05 16:25 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 18:18 UTC — released by scanner (agent; holding agent relaunched)
  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  8. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16736 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  9. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16783 (merged e5fd0f1). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions