You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (correctness): Transient POST failure silently consumes the head's single approval pass #16739
Blocked on PR #16736.src/pkg/github/workflow_auto_approval.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #16736.
PR: #16736 (#16736)
Perspective: correctness
Severity: low (P3)
Finding: Transient POST failure silently consumes the head's single approval pass
Evidence: src/pkg/github/workflow_auto_approval.go:316
SweepWorkflowApprovals claims the per-head pass before the first POST (workflow_auto_approval.go:299-303). Only a *gh.ErrorResponse with 403/404 (:316) records permission_error into the ledger and the caption; any other failure — 5xx, network error, context cancel, or a 403 that go-github types as *RateLimitError/*AbuseRateLimitError (github.go:1069/1105) — hits only the Warn at :326. The head is then never retried (previous.attempted) and nothing in the ledger, /api/status or the CI caption says the hive gave up, so a gated dependabot head that hit a secondary rate limit on its one attempt waits for a human click with no signal. Within #16603's 'one pass per head' contract, so advisory; the small fix is to leave attempted unset on non-2xx/403/404 outcomes so the next sweep retries.
Unblocked: #16736 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16736 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).Claim history
scanner(agent on hive hosted-available-oke-11-placeholder-r05x)scanner(agent; holding agent relaunched)hivecommons-hive commentedon Nov 5, 2026
Unblocked: #16736 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.