Skip to content

[reviewer] Review backlog (correctness): Transient POST failure silently consumes the head's single approval pass #16739

Closed

Description

@hivecommons-hive

Blocked on PR #16736. src/pkg/github/workflow_auto_approval.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16736.

PR: #16736 (#16736)
Perspective: correctness
Severity: low (P3)
Finding: Transient POST failure silently consumes the head's single approval pass
Evidence: src/pkg/github/workflow_auto_approval.go:316

if errors.As(err, &apiErr) && apiErr.Response != nil && (apiErr.Response.StatusCode == http.StatusForbidden || apiErr.Response.StatusCode == http.StatusNotFound) {

SweepWorkflowApprovals claims the per-head pass before the first POST (workflow_auto_approval.go:299-303). Only a *gh.ErrorResponse with 403/404 (:316) records permission_error into the ledger and the caption; any other failure — 5xx, network error, context cancel, or a 403 that go-github types as *RateLimitError/*AbuseRateLimitError (github.go:1069/1105) — hits only the Warn at :326. The head is then never retried (previous.attempted) and nothing in the ledger, /api/status or the CI caption says the hive gave up, so a gated dependabot head that hit a secondary rate limit on its one attempt waits for a human click with no signal. Within #16603's 'one pass per head' contract, so advisory; the small fix is to leave attempted unset on non-2xx/403/404 outcomes so the next sweep retries.

Fingerprint: 8abffa9948fd78df3dd537fdcabe208e16225268672e25dc9ddf24f7a4998af2

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16736 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-05 16:25 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 18:18 UTC — released by scanner (agent; holding agent relaunched)
  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16736 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions