You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (intent-alignment): Gateway model vote depends solely on live ModelOverride once pack fills operator agents' config models #16733
Blocked on PR #16731. This finding came from reviewing PR #16731 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16731.
PR: #16731 (#16731)
Perspective: intent-alignment
Severity: low (P3)
Finding: Gateway model vote depends solely on live ModelOverride once pack fills operator agents' config models
Evidence: src/pkg/dashboard/api_packs.go:1220
hiveAgentBackends only counts a config model when ModelOwner != pack (api_packs.go:1220-1222). In the reporter's override-placed hive, this apply also writes scanner/quality/guide's config model as pack-owned (api_packs.go:232-235, 257-265), so after that the only durable source for the gateway model is the replayed ModelOverride from hive-state.json. If that state is lost or an operator clears the overrides, hiveGatewayModel returns "" and the repair branch at api_packs.go:257 clears every pack-owned model on the gateway again, re-creating the no-model launch. Not a regression (the pre-PR code cleared the model unconditionally) and tests do not cover override loss; a follow-up could treat a pack-written model on a gateway with no default_model as a sticky fallback rather than re-deriving it on every apply.
Unblocked: #16731 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16731 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)hivecommons-hive commentedon Nov 5, 2026
Unblocked: #16731 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
fix(packs): retain gateway model after override loss
fix(packs): retain gateway model after override loss
fix(packs): retain gateway model after override loss (#16735)