You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (style): Rewritten log line keeps the key "model" for the pre-change value #16732
Blocked on PR #16731. This finding came from reviewing PR #16731 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16731.
PR: #16731 (#16731)
Perspective: style
Severity: info (P3)
Finding: Rewritten log line keeps the key "model" for the pre-change value
Evidence: src/pkg/dashboard/api_packs.go:259
s.logger.Info("setting pack model on gateway-routed agent to the gateway's model",
The former 'clearing pack model' log logged the model being cleared under "model"; the new 'setting pack model ... to the gateway's model' line keeps "model" for the old value next to "gateway_model" for the new one, so a reader of the log sees model= on a line that says the model is being set. Renaming the key to "old_model" (or "from") would read unambiguously. Advisory only.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #16731 (#16731) and folded into this issue because it is a style finding at the same symbol or lines of src/pkg/dashboard/api_packs.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
[reviewer] Review backlog (style): hiveGatewayModel evaluated in the if-init for every existing pack agent
hiveGatewayModel evaluated in the if-init for every existing pack agent (src/pkg/dashboard/api_packs.go:257)
Perspective: style
Severity: info (P3)
Finding: hiveGatewayModel evaluated in the if-init for every existing pack agent
Evidence: src/pkg/dashboard/api_packs.go:257
if gwModel := s.hiveGatewayModel(hiveBackends, pa.Name, existing.Backend); onForeignGateway && ... computes the vote tally for agents that are not on a foreign gateway at all (CLI backends), with the guard applied only afterwards. hiveGatewayModel is cheap and returns "" for a CLI backend via DefaultInferenceModel, so this is readability only: guarding on onForeignGateway first and then computing gwModel inside would make the intent clearer. Advisory only.
Unblocked: #16731 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 5, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #16731 (#16731) and folded into this issue because it is a style finding at the same symbol or lines of
src/pkg/dashboard/api_packs.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.[reviewer] Review backlog (style): hiveGatewayModel evaluated in the if-init for every existing pack agent
src/pkg/dashboard/api_packs.go:257)Perspective: style
Severity: info (P3)
Finding: hiveGatewayModel evaluated in the if-init for every existing pack agent
Evidence:
src/pkg/dashboard/api_packs.go:257hive/src/pkg/dashboard/api_packs.go
Line 257 in b3b75b2
if gwModel := s.hiveGatewayModel(hiveBackends, pa.Name, existing.Backend); onForeignGateway && ...computes the vote tally for agents that are not on a foreign gateway at all (CLI backends), with the guard applied only afterwards. hiveGatewayModel is cheap and returns "" for a CLI backend via DefaultInferenceModel, so this is readability only: guarding on onForeignGateway first and then computing gwModel inside would make the intent clearer. Advisory only.Fingerprint:
b5ff493922106fd323bb1414d864d7405a22030cac2a13588437d4abdf7fd0a6filed by Hive review backlog
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16731 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)fix: document gateway model log change
hivecommons-hive commentedon Nov 5, 2026
Unblocked: #16731 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🐛 fix(packs): clarify gateway model reconciliation logs (#16734)