Skip to content

[reviewer] Review backlog (style): Rewritten log line keeps the key "model" for the pre-change value #16732

Closed

Description

@hivecommons-hive

Blocked on PR #16731. This finding came from reviewing PR #16731 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16731.

PR: #16731 (#16731)
Perspective: style
Severity: info (P3)
Finding: Rewritten log line keeps the key "model" for the pre-change value
Evidence: src/pkg/dashboard/api_packs.go:259

s.logger.Info("setting pack model on gateway-routed agent to the gateway's model",

The former 'clearing pack model' log logged the model being cleared under "model"; the new 'setting pack model ... to the gateway's model' line keeps "model" for the old value next to "gateway_model" for the new one, so a reader of the log sees model= on a line that says the model is being set. Renaming the key to "old_model" (or "from") would read unambiguously. Advisory only.

Fingerprint: 5fbcc98cd09ee7cbbecbe4a9b29f1e2ed84f4821063a6d0d29460fa2e482f700

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #16731 (#16731) and folded into this issue because it is a style finding at the same symbol or lines of src/pkg/dashboard/api_packs.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    [reviewer] Review backlog (style): hiveGatewayModel evaluated in the if-init for every existing pack agent

    • hiveGatewayModel evaluated in the if-init for every existing pack agent (src/pkg/dashboard/api_packs.go:257)

    Perspective: style
    Severity: info (P3)
    Finding: hiveGatewayModel evaluated in the if-init for every existing pack agent
    Evidence: src/pkg/dashboard/api_packs.go:257

    if gwModel := s.hiveGatewayModel(hiveBackends, pa.Name, existing.Backend); onForeignGateway &&

    if gwModel := s.hiveGatewayModel(hiveBackends, pa.Name, existing.Backend); onForeignGateway && ... computes the vote tally for agents that are not on a foreign gateway at all (CLI backends), with the guard applied only afterwards. hiveGatewayModel is cheap and returns "" for a CLI backend via DefaultInferenceModel, so this is readability only: guarding on onForeignGateway first and then computing gwModel inside would make the intent clearer. Advisory only.

    Fingerprint: b5ff493922106fd323bb1414d864d7405a22030cac2a13588437d4abdf7fd0a6

    filed by Hive review backlog

  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16731 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-05 08:28 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 08:33 UTC — released by Karibhou (contributor; lease revoked)
  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  8. added a commit that references this issue on Nov 5, 2026
  9. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16731 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions