Skip to content

[reviewer] Review backlog (correctness): DCOSplitHiveIdentity marker is never cleared by an App-only recompute #16711

Closed

Description

@hivecommons-hive

Blocked on PR #16688. This finding came from reviewing PR #16688 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16688.

PR: #16688 (#16688)
Perspective: correctness
Severity: low (P3)
Finding: DCOSplitHiveIdentity marker is never cleared by an App-only recompute
Evidence: src/pkg/stagelabels/store.go:2643

if hiveIdentity {

Store.NoteDCO only ever sets DCOSplitHiveIdentity (store.go:2643-2645) and never resets it. If a record was marked while project.ai_author was configured, then ai_author is removed and the head changes, NoteDCO(hiveIdentity=false) rewrites the counts but leaves the stale marker set. Re-configuring ai_author later makes stageDCO (automerge_stage_dco.go:146) trust that App-only split, so a hive-identity commit stays filed as 'other' for that head — the #16707 symptom, limited to a toggle-off/on window. Carried verbatim from v5 (#16709); fix is to set r.DCOSplitHiveIdentity = hiveIdentity on rewrite rather than only setting it to true.

Fingerprint: 71953293fbba684a2e836e55f266d6362d8e621450bfac1deb7b3e0214fabbda

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #16710: both cite src/pkg/stagelabels/store.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  5. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16688 is no longer open. This issue is actionable again.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  7. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16688 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  8. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-07 14:36 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-07 15:21 UTC — released by scanner (agent; holding agent relaunched)
  9. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Intentional on v5: NoteDCO clears the marker on a new head (store.go ~2654) and keeps it on a same-head App-only refresh; TestStoreNoteDCONewHeadClearsHiveIdentityMarker (#16710) asserts this. Resetting unconditionally would force a re-read every cycle and break that test. Recommend closing as not planned.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions