Skip to content

[reviewer] Review backlog (security): DCOSplitHiveIdentity is never cleared when a new head is cached App-only after ai_author is removed #16710

Closed

Description

@hivecommons-hive

Blocked on PR #16709. This finding came from reviewing PR #16709 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16709.

PR: #16709 (#16709)
Perspective: security
Severity: low (P3)
Finding: DCOSplitHiveIdentity is never cleared when a new head is cached App-only after ai_author is removed
Evidence: src/pkg/stagelabels/store.go:2495

if hiveIdentity {

NoteDCO only ever sets DCOSplitHiveIdentity (store.go:2495-2497); with hiveIdentity=false it overwrites DCOHead/counts for a new head but leaves a previously-set true marker in place. If project.ai_author is removed, a new head is pushed (App-only split cached under the stale true flag), and ai_author is later re-added, the stageDCO guard (automerge_stage_dco.go:146) sees the flag and serves the App-only split instead of re-reading — the same symptom #16707 fixes, for the remove/re-add sequence. Adjacent config churn edge, not part of the #16707 contract. Remediation: set r.DCOSplitHiveIdentity = hiveIdentity whenever the head changes (r.DCOHead != head), only preserving a true flag for same-head refreshes.

Fingerprint: 694b3d582511f9894b35650f5dba991efd59c62f86a2871b034f442dd89e05bd

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16709 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-05 03:37 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16709 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions