Skip to content

[reviewer] Review backlog (intent-alignment): dco_split_hive_identity is set even for App-only splits, so configuring project.ai_author later does not trigger the one-time re-read #16707

Closed

Description

@hivecommons-hive

Blocked on PR #16706. This finding came from reviewing PR #16706 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16706.

PR: #16706 (#16706)
Perspective: intent-alignment
Severity: low (P3)
Finding: dco_split_hive_identity is set even for App-only splits, so configuring project.ai_author later does not trigger the one-time re-read
Evidence: src/pkg/stagelabels/store.go:2493

r.DCOSplitHiveIdentity = true

Store.NoteDCO unconditionally sets r.DCOSplitHiveIdentity = true (store.go:2493), and the caller invokes NoteDCO on every pass where dcoRead is true (automerge_stage_labels.go:1192-1194) including when policy.HiveAuthor is nil and the split was therefore computed App-only (automerge_stage_dco.go:166). stageDCO's re-read guard (automerge_stage_dco.go:146) only fires when the flag is absent, so a deployment that configures project.ai_author after records have been cached will keep serving the App-only split for in-flight heads until a new head is pushed — the same wait-for-a-person symptom #16701 fixes for the code-change case. Adjacent to #16701 (which is about records cached before this code existed), not blocking. Remediation if wanted: have NoteDCO take a hiveIdentity bool (policy.HiveAuthor != nil) and set the flag only when true.

Fingerprint: 548fd9735fa3d05b644e6e50e1242e15ce92a73b263a3907ddfe8295b8e069dc

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16706 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  6. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16706 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-05 03:14 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions