Skip to content

[reviewer] Review backlog (correctness): Stage-store DCO split cached by pre-#16685 code misclassifies ai_author commits as 'other' until the head moves #16704

Closed

Description

@hivecommons-hive

Blocked on PR #16688. This finding came from reviewing PR #16688 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16688.

PR: #16688 (#16688)
Perspective: correctness
Severity: low (P3)
Finding: Stage-store DCO split cached by pre-#16685 code misclassifies ai_author commits as 'other' until the head moves
Evidence: src/pkg/github/automerge/automerge_stage_dco.go:142

stageDCO returns the cached split (unsignedHive: rec.DCOUnsignedHive, unsignedOther: u - rec.DCOUnsignedHive) at automerge_stage_dco.go:132-142 whenever the record has a DCO result for the head; those counts were computed App-only by dcoCommitByHive before this change. adoptionDCORepairMode (automerge_contributor_adopt.go:343) now requires DCOUnsignedOther == 0 even for hiveAuthored PRs, so an already-open hive-authored base-repo PR whose unsigned commits are project.ai_author-linked (cached as unsignedOther>0) flips from in-place amend to wait-for-a-person ("") after upgrade, until a new head forces a re-read. Pre-existing on v5 (carried commit 4e7e404), not introduced by the forward-merge; a cache-version bump or ignoring the cached split when isHive is non-nil and DCOUnsignedHive==0 would clear it.

Fingerprint: 2d9fa6ba520a2163a0b3069f662ec6ea351a9896f2d2e4e36b37ad478d0b9d14

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #16701: both cite src/pkg/github/automerge/automerge_stage_dco.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  5. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16688 is no longer open. This issue is actionable again.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 7, 2026
  7. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16688 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  8. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-11-07T14:35:50Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute

  9. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Nov 7, 2026
  10. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-07 14:35 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-07 15:21 UTC — released by scanner (agent; holding agent relaunched)
  11. hivecommons-hive commented on Nov 7, 2026

    @hivecommons-hive
    ContributorAuthor

    Not a bug on v5: stageDCO only trusts a cached split when policy.HiveAuthor == nil || rec.DCOSplitHiveIdentity (automerge_stage_dco.go:146, from #16701), so an App-only cached split is re-read when a hive identity is configured. Recommend closing as not planned.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions