Skip to content

[reviewer] Review backlog (style): squashUnsafeHive still uses App-only ownership, inconsistent with the new unsigned split in the same loop #16703

Closed

Description

@hivecommons-hive

Blocked on PR #16698. This finding came from reviewing PR #16698 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16698.

PR: #16698 (#16698)
Perspective: style
Severity: low (P3)
Finding: squashUnsafeHive still uses App-only ownership, inconsistent with the new unsigned split in the same loop
Evidence: src/pkg/github/automerge/automerge_stage_dco.go:86

} else if !selfSquash && dcoCommitByHive(rc, appLogin) && !messageHasPRAuthorSignoff(msg, prAuthor) {

In dcoCommitStatsForHive the unsigned branch (:81) now uses dcoCommitOwnedByHive(rc, appLogin, isHive) while the squash-unsafe branch (:86) still uses dcoCommitByHive(rc, appLogin). A signed commit GitHub links to project.ai_author on a non-hive-authored PR (selfSquash false) is therefore not counted squash-unsafe, although the same commit unsigned is now the hive's. Not part of #16685 (which is about re-signing), but the two halves of one loop now apply different ownership definitions; consider passing isHive to the squash-unsafe test as well.

Fingerprint: 9a8889e6aeda8c7c02079927062a11188b8c11a645a4175430755e8d1f26ec91

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16698 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16698 is no longer open. This issue is actionable again.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-05 02:43 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions